bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid

Abierto
  • ¿Algo no está bien?
#5,058 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

  • #5059 de @shafiktanbir — cerrado sin fusionar
  • #5070 de @MilindChatrabhuji — cerrado sin fusionar
  • #5086 de @ghazy2001 — cerrado sin fusionar

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
39/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
nextjs, typescript
Área
backend, frontend

Línea de trabajo

Start in apps/webapp/app/v3/featureFlags.server.ts at mergeOrgFeatureFlags and inspect how stored organization flags are parsed; the reproduction shows a valid override being lost when another stored value is invalid. Then review FeatureFlagsDialog.tsx for unsetFlag and the derived grace-stamp rows. Done means valid overrides survive invalid stored values, unsetting clears related derived values, and derived rows stay read-only when unlocked; an open linked pull request indicates this work may already be underway.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Provide environment information

System:
OS: Linux 6.8 Ubuntu
Binaries:
Node: 22.14.0
pnpm: 9.15.0

Describe the bug

In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"), the v1 and v2 admin org feature-flag routes were updated to read stored flags key-by-key via parseStoredOrgFlags(organization.featureFlags).valid, and saves now intentionally keep untouched invalid values and unknown keys from newer releases in Organization.featureFlags.

However, mergeOrgFeatureFlags in apps/webapp/app/v3/featureFlags.server.ts (used by resolveOrganizationFeatureFlags) still validates the entire orgFeatureFlags object at once with validatePartialFeatureFlags(orgFeatureFlags):

export function mergeOrgFeatureFlags(
  globalFlags: Partial<FeatureFlagCatalog>,
  orgFeatureFlags: unknown
) {
  const parsed = orgFeatureFlags
    ? validatePartialFeatureFlags(orgFeatureFlags as Record<string, unknown>)
    : ({ success: false } as const);
  return { ...globalFlags, ...(parsed.success ? parsed.data : {}) };
}

If an org has one invalid stored flag value in Organization.featureFlags (which admin saves now keep), validatePartialFeatureFlags fails for the whole blob and mergeOrgFeatureFlags drops all of the org's valid overrides (hasWebhooksAccess, hasQueryAccess, hasLogsPageAccess, hasAiAccess, etc.), even though the admin flags dialog and /admin/api/v1/orgs/:orgId/feature-flags show them as active.

Two small related issues in FeatureFlagsDialog.tsx:

  • unsetFlag(key) only deletes next[key] without clearing derivedFlagsClearedWith(key), so unsetting runOpsMintKind leaves runOpsMintKindPrev and runOpsMintKindFlippedAt shown as set in the dialog list and JSON preview.
  • Checking "Unlock read-only flags" unlocks effect === "derived" grace-stamp rows (runOpsMintKindPrev, runOpsMintKindFlippedAt, runOpsMintShardSetPrev, runOpsMintShardSetFlippedAt) into editable controls, even though the server strips and recomputes them on save.
Reproduction repo

https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314

To reproduce
  1. Call mergeOrgFeatureFlags({ hasLogsPageAccess: false }, { hasLogsPageAccess: true, realtimeBackend: "not-a-backend" }) (or save a valid flag via /admin/api/v2/orgs/:organizationId/feature-flags on an org that has an existing invalid flag).
  2. mergeOrgFeatureFlags returns { hasLogsPageAccess: false } instead of { hasLogsPageAccess: true } because validatePartialFeatureFlags fails on realtimeBackend.
Suggested fix

Use parseStoredOrgFlags(orgFeatureFlags).valid in mergeOrgFeatureFlags, and in FeatureFlagsDialog.tsx clear derivedFlagsClearedWith(key) in unsetFlag and keep effect === "derived" flags read-only when unlocked.

Additional information

No response

Image
Lenguaje dominante
TypeScript
Estrellas
16.5k
Forks
1.5k
Merge medio
1 d 15 h
PR fusionados (30 d)
17

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de triggerdotdev/trigger.dev

Todos los issues de triggerdotdev/trigger.dev

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.