Completion markers assume command lists run in recording order
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 15/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- cpp
研究方向
Start from clean/rr_f/runtime/src/rr_runtime.cpp around marker_done (:496), pump (:505) and the slot wait (:2570), then look at the transient and arena release paths at :3448 and :3544. The fix is a design choice between a per-recording marker ring and documenting the submit-order contract. Done means the WARP test that records lists A (serial 1) and B (serial 2), runs only B, and asserts serial 1 is not done passes.
由索引模型根據 Issue 內容生成。
描述
What happens
Both runtimes use one scalar completion marker and treat "marker observed >= s" as "every recording up to s is done". The marker is written by the recorded list, so this only holds if lists execute in the order they were recorded.
- RR:
clean/rr_f/runtime/src/rr_runtime.cpp:496(marker_done),pump(:505), slot wait (:2570), frame marker (:3408), transient marker (:3525). - Model M:
clean/runtime/device_d3d12.cpp:400(end_external),:421(external_done),:996(wait_external).
Model M: the marker belongs to one device, so to one context. If one context's frames ran out of order, its temporal history would already be wrong, so this is not a case that matters in practice.
RR: the marker is runtime-wide (rt.marker, rt.serial) and shared by every instance and by transient copies. If instance B's list runs before instance A's earlier list, B's serial covers A's outstanding work, and defer_release of A's old arena (:3448) or of a transient (:3544) can release early. Out-of-order execution can also move the marker backwards, because the lower serial is written last. That causes slot-wait timeouts (:2572) and failed frames rather than a use-after-free.
When it can happen
Rarely. A use-after-free needs several RR instances (for example two viewports) with lists submitted out of order or on different queues, and an arena regrow, resize or transient release inside that window. Transient copies recorded on a list that is submitted after the evaluate list already break the data dependency.
Found by reading the code. It has not been reproduced.
To do
This is a design discussion. Options:
- Replace the single maximum with a per-recording marker ring. The readback buffer is 256 bytes, so 64 dwords. Each recording writes its serial into dword
s % N, and recordingsis done when that dword equalss(low 32 bits) or a later serial that maps to the same dword. Bound the recordings in flight to N; the slot waits already bound this. Wrap handling needs care. - Or document the contract: one RR instance at a time, or submit in recording order.
Test
WARP. Record list A (serial 1), then list B (serial 2), using only WriteBufferImmediate. Execute B alone and wait for the queue. Assert that "serial 1 done" is false. This fails today and would pass with the ring.
Related: #63, #62, #65.
- 主要語言
- C++
- 星號
- 12
- 分支
- 2
- 平均合併
- 3 小時 10 分鐘
- 30 天內合併 PR
- 171
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
phantoslayer21/wronggpu 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#275 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
phantoslayer21/wronggpu#274 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#241 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 74/100
phantoslayer21/wronggpu#234 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 80/100
phantoslayer21/wronggpu#233 ·
維護者通常 1 天內回覆
查看 phantoslayer21/wronggpu 的全部 Issue
相似的 Issue
-
ai_p2
難度 2/5 1-3 小時 新手友好度 80/100
ClickHouse/ClickHouse#132519 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
juce-framework/JUCE#1810 ·
-
難度 1/5 1 小時以內 新手友好度 82/100
petercorke/robotics-toolbox-python#952 ·
維護者通常 1 天內回覆
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit status未關閉func:engine type:bug
難度 2/5 1-3 小時 新手友好度 72/100
NatronGitHub/Natron#1276 ·
維護者通常 1 天內回覆
-
難度 1/5 1-3 小時 新手友好度 77/100
維護者通常 1 天內回覆