0.6.6: follow-ups from the Model L hybrid default review (#256)

未關閉
#258 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
cpp
領域
devtools, testing

研究方向

Start with the five follow-ups listed in the issue and locate the game-path timeout tests, D3D12 kernel manifest and release diagnostics checks, scan mutant ISA output handling, ISA conversion rule, and Model M barrier and kernel-substitution switches. Read the relevant tests and build paths first; add each specified regression case and verify both default and --isa builds where requested, plus the release diagnostics checks. Done means all five follow-ups have regression coverage and the diagnostic switches are limited to diagnostic builds on every route.

由索引模型根據 Issue 內容生成。

描述

Follow-ups from the review rounds of #256 (Model L hybrid form as the native D3D12 default). None of them changes what a default run outputs. They are tracked here for 0.6.6.

1. Wider game-path timeout test

The forced-timeout test through the game interface covers a timeout on a later frame, one output format on the direct route, and RGB values. Extend it to:

  • both proxy routes (sRGB or non-UAV outputs as well as UAV outputs);
  • byte comparisons that include alpha;
  • an exact count of every log line emitted for the stuck, refused and reset frames;
  • the reset compared with a fresh context's first frame in the pipelined mode as well as the synchronous one.

2. Legacy partial manifests

A D3D12 kernel manifest written before probe entries were marked can keep an unmarked probe (for example l_q7_s2a_probe_m1) through a later partial --only build, and the embedding step would accept it. Resolve manifest entries against the current kernel declarations, or refuse unknown and legacy entries fail-closed, and extend the release diagnostics check to that probe's file name. Add a legacy-manifest negative control.

3. ISA output of scan mutants

With --isa, the scan mutants' ISA and statistics are written under the build's dx12/isa folder, outside the temporary folder that holds the mutants. Keep mutant diagnostics in the temporary folder, and test the --isa build as well as the default one.

4. FP16 representability of scalar literals in the ISA rule

The conversion rule accepts any literal moved into a scalar register as an FP16 value. A literal that is FP32 but not FP16-exact (for example one just above an FP8 midpoint) would pass, although rounding it directly to FP8 can differ from rounding it through FP16 first. Track literal bit values and accept them as conversion sources only when they are FP16-exact. Add that negative control.

5. Barrier and kernel-substitution switches on the Model M route

The barrier and kernel-substitution switches are ignored on the release Model L hybrid route but are still honoured on the release Model M route. Limit them to diagnostic builds on every route, and extend the release diagnostics check to them.

主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。