0.6.6: follow-ups from the Model L hybrid default review (#256)

Aberta
#258 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
cpp
Domínio
devtools, testing

Direção de pesquisa

Start with the five follow-ups listed in the issue and locate the game-path timeout tests, D3D12 kernel manifest and release diagnostics checks, scan mutant ISA output handling, ISA conversion rule, and Model M barrier and kernel-substitution switches. Read the relevant tests and build paths first; add each specified regression case and verify both default and --isa builds where requested, plus the release diagnostics checks. Done means all five follow-ups have regression coverage and the diagnostic switches are limited to diagnostic builds on every route.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Follow-ups from the review rounds of #256 (Model L hybrid form as the native D3D12 default). None of them changes what a default run outputs. They are tracked here for 0.6.6.

1. Wider game-path timeout test

The forced-timeout test through the game interface covers a timeout on a later frame, one output format on the direct route, and RGB values. Extend it to:

  • both proxy routes (sRGB or non-UAV outputs as well as UAV outputs);
  • byte comparisons that include alpha;
  • an exact count of every log line emitted for the stuck, refused and reset frames;
  • the reset compared with a fresh context's first frame in the pipelined mode as well as the synchronous one.

2. Legacy partial manifests

A D3D12 kernel manifest written before probe entries were marked can keep an unmarked probe (for example l_q7_s2a_probe_m1) through a later partial --only build, and the embedding step would accept it. Resolve manifest entries against the current kernel declarations, or refuse unknown and legacy entries fail-closed, and extend the release diagnostics check to that probe's file name. Add a legacy-manifest negative control.

3. ISA output of scan mutants

With --isa, the scan mutants' ISA and statistics are written under the build's dx12/isa folder, outside the temporary folder that holds the mutants. Keep mutant diagnostics in the temporary folder, and test the --isa build as well as the default one.

4. FP16 representability of scalar literals in the ISA rule

The conversion rule accepts any literal moved into a scalar register as an FP16 value. A literal that is FP32 but not FP16-exact (for example one just above an FP8 midpoint) would pass, although rounding it directly to FP8 can differ from rounding it through FP16 first. Track literal bit values and accept them as conversion sources only when they are FP16-exact. Add that negative control.

5. Barrier and kernel-substitution switches on the Model M route

The barrier and kernel-substitution switches are ignored on the release Model L hybrid route but are still honoured on the release Model M route. Limit them to diagnostic builds on every route, and extend the release diagnostics check to them.

Linguagem predominante
C++
Estrelas
12
Forks
2
Merge médio
3h 10min
PRs com merge (30d)
171

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de phantoslayer21/wronggpu

Todas as issues de phantoslayer21/wronggpu

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.