0.6.6: follow-ups from the Model L hybrid default review (#256)

オープン
#258 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp
領域
devtools, testing

調査の方向性

Start with the five follow-ups listed in the issue and locate the game-path timeout tests, D3D12 kernel manifest and release diagnostics checks, scan mutant ISA output handling, ISA conversion rule, and Model M barrier and kernel-substitution switches. Read the relevant tests and build paths first; add each specified regression case and verify both default and --isa builds where requested, plus the release diagnostics checks. Done means all five follow-ups have regression coverage and the diagnostic switches are limited to diagnostic builds on every route.

索引モデルが issue の本文から書いたものです。

説明

Follow-ups from the review rounds of #256 (Model L hybrid form as the native D3D12 default). None of them changes what a default run outputs. They are tracked here for 0.6.6.

1. Wider game-path timeout test

The forced-timeout test through the game interface covers a timeout on a later frame, one output format on the direct route, and RGB values. Extend it to:

  • both proxy routes (sRGB or non-UAV outputs as well as UAV outputs);
  • byte comparisons that include alpha;
  • an exact count of every log line emitted for the stuck, refused and reset frames;
  • the reset compared with a fresh context's first frame in the pipelined mode as well as the synchronous one.

2. Legacy partial manifests

A D3D12 kernel manifest written before probe entries were marked can keep an unmarked probe (for example l_q7_s2a_probe_m1) through a later partial --only build, and the embedding step would accept it. Resolve manifest entries against the current kernel declarations, or refuse unknown and legacy entries fail-closed, and extend the release diagnostics check to that probe's file name. Add a legacy-manifest negative control.

3. ISA output of scan mutants

With --isa, the scan mutants' ISA and statistics are written under the build's dx12/isa folder, outside the temporary folder that holds the mutants. Keep mutant diagnostics in the temporary folder, and test the --isa build as well as the default one.

4. FP16 representability of scalar literals in the ISA rule

The conversion rule accepts any literal moved into a scalar register as an FP16 value. A literal that is FP32 but not FP16-exact (for example one just above an FP8 midpoint) would pass, although rounding it directly to FP8 can differ from rounding it through FP16 first. Track literal bit values and accept them as conversion sources only when they are FP16-exact. Add that negative control.

5. Barrier and kernel-substitution switches on the Model M route

The barrier and kernel-substitution switches are ignored on the release Model L hybrid route but are still honoured on the release Model M route. Limit them to diagnostic builds on every route, and extend the release diagnostics check to them.

主要言語
C++
スター
12
フォーク
2
平均マージ
3時間 10分
マージ済み PR(30日)
171

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

phantoslayer21/wronggpu のほかの issue

phantoslayer21/wronggpu の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。