Model L: propagate a NaN through enc0's ReLU + FP8 step as the original does; converter check for non-finite weight codes

未關閉
#251 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
cpp, python

研究方向

Start with clean/l/reference/oracle.py and its _out_round relu_q8 mode, then compare the listed HIP and D3D12 kernels and the encoder block paths. Trace how the NaN-input case reaches the second linear and pack12 coefficients, and inspect clean/l/runner/l_hyb_stage_check.py for the separately reported leg. Done when the NaN cases match the oracle across implementations and the converter rejects non-finite weight codes with the stage and blob named.

由索引模型根據 Issue 內容生成。

描述

Problem

Model L's first input linear ends in a ReLU and an FP8 conversion: x1 = q8(max(0, RN16(b + W q))). When the
accumulator is NaN (a NaN input code in q, or a NaN weight code), the original keeps the NaN through the fused
ReLU + FP8 conversion. Our kernels give 0: max(0, NaN) returns 0 on the hardware and in the HIP code.

This affects every implementation of that step alike:

  • main's kernels: clean/l/kernels/l_ops.hip (linear_32_32<RELU = true>) and its D3D12 ports in
    clean/dx12/kernels/l_ops_linear.hlsl (l_linear_32_32_relu, l_linear_32_32_fused, via
    clean/dx12/hlsl/l_lin_px.hlsli);
  • the encoder block with the linears as its prologue (clean/dx12/kernels/swin_block.hlsl SW_SRC == 3,
    clean/dx12/kernels/fused_swin.hlsl);
  • the hybrid twins of the same step (D3D12 and HIP).

The reference oracle (clean/l/reference/oracle.py, _out_round mode relu_q8) keeps the NaN, so the hybrid stage
check's random NaN-input cases differ from it (the second linear's chain and the pack12 coefficients downstream).
Finite inputs are unaffected.

Spec references: L P3 item 13; spec 05 edge cases. Spec 03 maps NaN inputs to 0, and real converted models contain no
FP8 NaN weight codes, so this is not visible on real data. It was kept out of 0.6.5.

Until it is fixed, the random-weight legs of clean/l/runner/l_hyb_stage_check.py draw finite codes only, and one
dedicated NaN-input leg is reported separately (listed, neither pass nor fail).

Proposed fix

  1. In every implementation listed above, make the ReLU + FP8 step keep a NaN as the original does (one form shared by
    main's kernels, the hybrid twins and HIP, so the byte checks between them stay identical).
  2. Fold the dedicated NaN-input leg back into the pass/fail random legs of l_hyb_stage_check.py once the kernels
    match the oracle.

Converter validation

Add a check to the model converter's validation: a real converted model must contain no non-finite weight codes (no FP8
NaN codes, no FP16 NaN or infinity in the converted blobs). A model that fails is refused with one line naming the stage
and blob.

Tests

  • l_hyb_stage_check.py: the NaN-input leg passes under the normal rule (then merged into the random legs).
  • The byte checks (HIP == D3D12) for the linears and the fused encoder block stay identical, NaN cases included.
  • The converter check: one synthetic model with a NaN weight code is refused; the real models pass.
主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。