Model L: propagate a NaN through enc0's ReLU + FP8 step as the original does; converter check for non-finite weight codes

Aperta
#251 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp, python

Direzione di ricerca

Start with clean/l/reference/oracle.py and its _out_round relu_q8 mode, then compare the listed HIP and D3D12 kernels and the encoder block paths. Trace how the NaN-input case reaches the second linear and pack12 coefficients, and inspect clean/l/runner/l_hyb_stage_check.py for the separately reported leg. Done when the NaN cases match the oracle across implementations and the converter rejects non-finite weight codes with the stage and blob named.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

Model L's first input linear ends in a ReLU and an FP8 conversion: x1 = q8(max(0, RN16(b + W q))). When the
accumulator is NaN (a NaN input code in q, or a NaN weight code), the original keeps the NaN through the fused
ReLU + FP8 conversion. Our kernels give 0: max(0, NaN) returns 0 on the hardware and in the HIP code.

This affects every implementation of that step alike:

  • main's kernels: clean/l/kernels/l_ops.hip (linear_32_32<RELU = true>) and its D3D12 ports in
    clean/dx12/kernels/l_ops_linear.hlsl (l_linear_32_32_relu, l_linear_32_32_fused, via
    clean/dx12/hlsl/l_lin_px.hlsli);
  • the encoder block with the linears as its prologue (clean/dx12/kernels/swin_block.hlsl SW_SRC == 3,
    clean/dx12/kernels/fused_swin.hlsl);
  • the hybrid twins of the same step (D3D12 and HIP).

The reference oracle (clean/l/reference/oracle.py, _out_round mode relu_q8) keeps the NaN, so the hybrid stage
check's random NaN-input cases differ from it (the second linear's chain and the pack12 coefficients downstream).
Finite inputs are unaffected.

Spec references: L P3 item 13; spec 05 edge cases. Spec 03 maps NaN inputs to 0, and real converted models contain no
FP8 NaN weight codes, so this is not visible on real data. It was kept out of 0.6.5.

Until it is fixed, the random-weight legs of clean/l/runner/l_hyb_stage_check.py draw finite codes only, and one
dedicated NaN-input leg is reported separately (listed, neither pass nor fail).

Proposed fix

  1. In every implementation listed above, make the ReLU + FP8 step keep a NaN as the original does (one form shared by
    main's kernels, the hybrid twins and HIP, so the byte checks between them stay identical).
  2. Fold the dedicated NaN-input leg back into the pass/fail random legs of l_hyb_stage_check.py once the kernels
    match the oracle.

Converter validation

Add a check to the model converter's validation: a real converted model must contain no non-finite weight codes (no FP8
NaN codes, no FP16 NaN or infinity in the converted blobs). A model that fails is refused with one line naming the stage
and blob.

Tests

  • l_hyb_stage_check.py: the NaN-input leg passes under the normal rule (then merged into the random legs).
  • The byte checks (HIP == D3D12) for the linears and the fused encoder block stay identical, NaN cases included.
  • The converter check: one synthetic model with a NaN weight code is refused; the real models pass.
Lingua principale
C++
Stelle
12
Fork
2
Merge medio
3h 10m
PR unite (30g)
171

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di phantoslayer21/wronggpu

Tutte le issue di phantoslayer21/wronggpu

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.