Honor open-to-side placement when opening GitHub PR and issue links
維護者通常 2 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 82/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- github, typescript, vscode
研究方向
從src/github/externalUriOpener.ts開始，追蹤 opener 如何接收openContext並呼叫 PR 和 issue 概觀方法。在src/github/pullRequestOverview.ts中檢查現有的放置處理，接著為在指定側邊群組中建立和顯示面板新增迴歸測試。完成標準是兩種概觀類型都遵循ViewColumn.Beside，而一般開啟仍維持目前的行為。
由索引模型根據 Issue 內容生成。
描述
Summary
Opening a GitHub PR link with an explicit open-to-side request still opens/reveals the PR overview in the current editor group. The GitHub Pull Requests external URI opener receives a placement request from VS Code but does not forward it to the overview panel.
This was reproduced in a live Code OSS development instance using the Quick Open link support in https://github.com/microsoft/vscode/pull/342081 (implements https://github.com/microsoft/vscode/issues/342051).
Steps to reproduce
- Use a VS Code build with Quick Open link support and external-opener placement context, and enable the GitHub Pull Requests link handler.
- Sign in/authorize GitHub Pull Requests. Keep an existing document open in a single editor group.
- Press Ctrl+P and enter
https://github.com/microsoft/vscode/pull/342081. - Accept the Open Link result with Alt+Enter (an explicit open-to-side gesture).
Expected: The GitHub Pull Requests overview opens beside the originating document, preserving that document in its group.
Actual: The PR overview opens in the same editor group. No side group is created. The user also observed the same placement problem with Alt+click; the instrumented reproduction below specifically used Alt+Enter in Quick Open.
Live dbgjs evidence
A non-pausing breakpoint at MainThreadUriOpeners.createOpener recorded the context immediately before the call into the extension host:
{
"id": "GitHub.vscode-pull-request-github.issueOrPullRequest",
"uri": "https://github.com/microsoft/vscode/pull/342081",
"viewColumn": -2
}
-2 is ViewColumn.Beside. After the request, the workbench still had one editor group, containing the original Untitled-1 tab and the #342081 Support opening... PR tab.
This demonstrates that Quick Open and the workbench external-opener pipeline are forwarding the side-placement request; the PR extension is not honoring it. The temporary breakpoint was removed after tracing.
Code pointers / suggested fix
src/github/externalUriOpener.ts:37receives the open context, but currently usessourceUriwithout consuming the placement field supplied by the host.- The PR overview call at line 63 and issue overview call at line 72 omit placement.
PullRequestOverviewPanel.createOrShowat line 123 already has placement handling viatoTheSide/_getViewColumn.
Please honor openContext.viewColumn === vscode.ViewColumn.Beside when supplied by a supporting VS Code host, and forward the request for both PR and issue overviews. Preserve ordinary opening behavior when no side placement is requested. Include regression coverage for both creating a panel and revealing an existing panel in the requested side group. Issue-overview impact is inferred from the shared source path; the live reproduction was for a PR.
Environment
- Windows, Code OSS development build, VS Code branch used by microsoft/vscode#342081.
- Live placement trace: GitHub Pull Requests 0.170.0 (stable).
- The installed prerelease 0.171.2026101604 was also inspected; its URI opener likewise did not forward placement. Separate authentication/rendering problems encountered during setup are not the subject of this report.
Related navigation story: https://github.com/microsoft/vscode/issues/342050
Related Alt+click request: https://github.com/microsoft/vscode/issues/340724
- 主要語言
- TypeScript
- 星號
- 2.6k
- 分支
- 804
- 平均合併
- 2 天 1 小時
- 30 天內合併 PR
- 42
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
microsoft/vscode-pull-request-github 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
microsoft/vscode-pull-request-github#8792 ·
維護者通常 2 天內回覆
-
Add a setting to fully disable background PR state polling (causes editor to jump/scroll on focus regain)可能已有人在做 @alexr00 今天認領。 未關閉
microsoft/vscode-pull-request-github#9077 · 已指派 1 人 ·
維護者通常 2 天內回覆
-
難度 3/5 1-2 天 新手友好度 68/100
microsoft/vscode-pull-request-github#9076 ·
維護者通常 2 天內回覆
-
難度 3/5 1-2 天 新手友好度 55/100
microsoft/vscode-pull-request-github#9075 ·
維護者通常 2 天內回覆
-
Plugin no longer gives access to GitHub issues while using personal account.可能已有人在做 @alexr00 於 5 天前認領。 未關閉info-needed
microsoft/vscode-pull-request-github#9064 · 2 則留言 · 已指派 1 人 ·
維護者通常 2 天內回覆
查看 microsoft/vscode-pull-request-github 的全部 Issue
相似的 Issue
-
check:failed streams:edit
難度 2/5 1-3 小時 新手友好度 64/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 2 天內回覆
-
package:ios ships XCFrameworks with absolute symlinks, which SwiftPM refuses to extract可能已有人在做 @cusnirvladislav 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
callstackincubator/rock#740 ·
-
S: triage
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 2 天內回覆
-
area:workflow bug ready-for-human
難度 1/5 1 小時以內 新手友好度 78/100
fil-donadoni/tolaria#6108 ·
維護者通常 1 天內回覆