PR file list keeps the old base after the base branch changes outside VS Code
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- github, typescript, vscode
研究方向
Start by tracing the Pull Requests view refresh flow through pr.refreshList, createOrUpdatePullRequestModel(), and getChangeModels() in dist/extension.js, as identified in the issue. Check how cached file changes are invalidated when the base branch changes, then reproduce with a PR whose new base changes the file diff. Done means Refresh shows the same file changes as GitHub’s “Files changed” tab without reloading the window.
由索引模型根據 Issue 內容生成。
描述
- Extension version: 0.170.0
- VSCode Version: 1.142.0
- OS: Windows 11
- Repository Clone Configuration (single repository/fork of an upstream repository): single repository
- GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GitHub.com
Steps to Reproduce:
- Have an open PR listed in the Pull Requests view.
- Change its base branch outside VS Code, for example with
gh pr edit <number> --base <branch>, to a branch where the PR's files differ. - Expand the PR in the Pull Requests view, then click Refresh and expand it again.
Result: the file list still compares against the old base. In my case, files that the new base already has as renamed show as deleted and added. Only Developer: Reload Window fixes it. GitHub's "Files changed" tab shows them as modified.
Expected: Refresh shows the files against the new base.
From reading dist/extension.js (not debugged): pr.refreshList calls forceClearCache(), and createOrUpdatePullRequestModel() keeps the existing model and calls update(), which sets the new base. Nothing clears _fileChanges, and getChangeModels() reuses it while it isn't empty.
- 主要語言
- TypeScript
- 星號
- 2.6k
- 分支
- 804
- 平均合併
- 1 天 16 小時
- 30 天內合併 PR
- 53
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
microsoft/vscode-pull-request-github 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
microsoft/vscode-pull-request-github#9072 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
microsoft/vscode-pull-request-github#8792 ·
維護者通常 1 天內回覆
-
Separate link openers for issues and pull requests可能已有人在做 @hediet 於 2 天前認領。 未關閉feature-request
microsoft/vscode-pull-request-github#9082 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
Add a setting to fully disable background PR state polling (causes editor to jump/scroll on focus regain)可能已有人在做 @alexr00 於 3 天前認領。 未關閉
microsoft/vscode-pull-request-github#9077 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 55/100
microsoft/vscode-pull-request-github#9075 ·
維護者通常 1 天內回覆
查看 microsoft/vscode-pull-request-github 的全部 Issue
相似的 Issue
-
level/task type/bug
難度 2/5 1-3 小時 新手友好度 75/100
wazuh/wazuh-dashboard-plugins#9508 ·
維護者通常 1 天內回覆
-
Testnet EOL page links Zonescan mainnet可能已有人在做 @napelvs 今天認領。 未關閉
難度 1/5 1 小時以內 新手友好度 76/100
-
難度 2/5 1-3 小時 新手友好度 78/100
Azure-Samples/azure-search-openai-demo#3249 ·
維護者通常 1 天內回覆
-
[Docs] docs/architecture.mermaid leaves out 21 of the 51 src/ directories可能已有人在做 @uyg7x 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
enhancement status:needs-triage
難度 2/5 1-3 小時 新手友好度 68/100
dongdongbh/Mindwtr#1438 ·
維護者通常 1 天內回覆