Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Honor open-to-side placement when opening GitHub PR and issue links

Aberta Para iniciantes
  • Algo errado?
#9,072 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
82/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github, typescript, vscode
Domínio
developer-experience

Direção de pesquisa

Comece em src/github/externalUriOpener.ts e acompanhe como o abridor recebe openContext e chama os métodos de visão geral de PR e issue. Confira em src/github/pullRequestOverview.ts o tratamento de posicionamento existente e, em seguida, adicione testes de regressão para criar e revelar painéis no grupo lateral solicitado. O trabalho estará concluído quando os dois tipos de visão geral respeitarem ViewColumn.Beside e as aberturas comuns mantiverem o comportamento atual.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Summary

Opening a GitHub PR link with an explicit open-to-side request still opens/reveals the PR overview in the current editor group. The GitHub Pull Requests external URI opener receives a placement request from VS Code but does not forward it to the overview panel.

This was reproduced in a live Code OSS development instance using the Quick Open link support in https://github.com/microsoft/vscode/pull/342081 (implements https://github.com/microsoft/vscode/issues/342051).

Steps to reproduce

  1. Use a VS Code build with Quick Open link support and external-opener placement context, and enable the GitHub Pull Requests link handler.
  2. Sign in/authorize GitHub Pull Requests. Keep an existing document open in a single editor group.
  3. Press Ctrl+P and enter https://github.com/microsoft/vscode/pull/342081.
  4. Accept the Open Link result with Alt+Enter (an explicit open-to-side gesture).

Expected: The GitHub Pull Requests overview opens beside the originating document, preserving that document in its group.

Actual: The PR overview opens in the same editor group. No side group is created. The user also observed the same placement problem with Alt+click; the instrumented reproduction below specifically used Alt+Enter in Quick Open.

Live dbgjs evidence

A non-pausing breakpoint at MainThreadUriOpeners.createOpener recorded the context immediately before the call into the extension host:

{
  "id": "GitHub.vscode-pull-request-github.issueOrPullRequest",
  "uri": "https://github.com/microsoft/vscode/pull/342081",
  "viewColumn": -2
}

-2 is ViewColumn.Beside. After the request, the workbench still had one editor group, containing the original Untitled-1 tab and the #342081 Support opening... PR tab.

This demonstrates that Quick Open and the workbench external-opener pipeline are forwarding the side-placement request; the PR extension is not honoring it. The temporary breakpoint was removed after tracing.

Code pointers / suggested fix

Please honor openContext.viewColumn === vscode.ViewColumn.Beside when supplied by a supporting VS Code host, and forward the request for both PR and issue overviews. Preserve ordinary opening behavior when no side placement is requested. Include regression coverage for both creating a panel and revealing an existing panel in the requested side group. Issue-overview impact is inferred from the shared source path; the live reproduction was for a PR.

Environment

  • Windows, Code OSS development build, VS Code branch used by microsoft/vscode#342081.
  • Live placement trace: GitHub Pull Requests 0.170.0 (stable).
  • The installed prerelease 0.171.2026101604 was also inspected; its URI opener likewise did not forward placement. Separate authentication/rendering problems encountered during setup are not the subject of this report.

Related navigation story: https://github.com/microsoft/vscode/issues/342050
Related Alt+click request: https://github.com/microsoft/vscode/issues/340724

Linguagem predominante
TypeScript
Estrelas
2.6k
Forks
805
Merge médio
1d 23h
PRs com merge (30d)
41

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de microsoft/vscode-pull-request-github

Todas as issues de microsoft/vscode-pull-request-github

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.