Range sync: step past a span with no blocks instead of failing the peer that serves it
維護者通常 6 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- rust
研究方向
Start with RangeSyncState::complete_batch in crates/net/p2p/src/lib.rs and the Lean and Beacon BlocksByRange handlers named in the issue. Read the stall-window note in docs/spec_deviations.md and the linked discussion in lambdaclass/ethlambda#791 to understand the prior attempt. A fix should advance across empty spans, verify skips using the next batch's parent link, and retry or count a failure when that check does not match.
由索引模型根據 Issue 內容生成。
描述
Problem. Range sync cannot pass a stretch of slots with no block on the chain, such as a long run of missed proposals during a non-finality incident.
- A
BlocksByRangeanswer with no block in the requested range counts as a failed request. Lean:crates/net/p2p/src/req_resp/handlers.rs:943-953. Beacon:handlers.rs:2905-2913. - The range session's cursor only moves when a batch delivers blocks (
RangeSyncState::complete_batch,crates/net/p2p/src/lib.rs:865-867). Across a span a whole batch long with no block on the chain, range sync therefore never advances. - The honest peers asked for that span cool down. After three such answers in a row they become suspects (
SUSPECT_AFTER_FAILURES,crates/net/p2p/src/peer_heads.rs), and their claims stop counting towards the network head. - The node can then read as synced while it is still behind, and only the parent lookups of newer gossip blocks fill the gap.
The trade-off is stated in docs/spec_deviations.md (the stall-window bullet of the sync-gate section). It was discussed in rounds seven, eight, eleven and thirteen of lambdaclass/ethlambda#791.
Why it is out of that PR's scope.
mainalready stops at such a span. Its lean handler fails an empty answer and returns beforecomplete_batch(crates/net/p2p/src/req_resp/handlers.rs:817-821onmain), so its cursor does not move either.- Excusing empty answers in place was tried and reverted in lambdaclass/ethlambda#791. A peer claiming a high head was then excused on every batch below it, and took a batch on every
Statusit sent. - The fix is a change to range sync itself, not to the sync gate.
What a fix could look like.
- Advance the cursor: when a peer whose
Statushead is past the span answers it empty, move the cursor past it. - Remember the skip: keep the skipped span and who answered it.
- Check it with the next batch: use the parent link
HeadWatch::note_deliveryalready uses. If the next batch's first block names, as its parent, the last block delivered below the span, the span was empty and the peer is credited. - Otherwise: re-ask the span from another peer, and count a failure against the peer that answered it empty.
- 主要語言
- Rust
- 星號
- 86
- 分支
- 34
- 平均合併
- 9 天 20 小時
- 30 天內合併 PR
- 77
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
lambdaclass/ethlambda 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#850 ·
維護者通常 6 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 個 reaction ·
維護者通常 6 天內回覆
-
Run all gossip validation tests可能重新可做 @dicethedev 於 9 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 則留言 ·
維護者通常 6 天內回覆
-
Handle malformed DB data可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 則留言 ·
維護者通常 6 天內回覆
-
Document architectural choices可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 則留言 ·
維護者通常 6 天內回覆
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 84/100
antithesishq/bombadil#473 ·
維護者通常 2 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 72/100
libracoder/kiri#669 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 88/100
維護者通常 5 天內回覆
-
autofixer: follow-up
難度 2/5 1-3 小時 新手友好度 75/100
tursodatabase/turso#12217 ·
維護者通常 1 天內回覆
-
Declare the CMS schema library in the optional recipients extra可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉area:python in-progress
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆