Range sync: step past a span with no blocks instead of failing the peer that serves it

オープン
#812 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 6 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust

調査の方向性

Start with RangeSyncState::complete_batch in crates/net/p2p/src/lib.rs and the Lean and Beacon BlocksByRange handlers named in the issue. Read the stall-window note in docs/spec_deviations.md and the linked discussion in lambdaclass/ethlambda#791 to understand the prior attempt. A fix should advance across empty spans, verify skips using the next batch's parent link, and retry or count a failure when that check does not match.

索引モデルが issue の本文から書いたものです。

説明

Problem. Range sync cannot pass a stretch of slots with no block on the chain, such as a long run of missed proposals during a non-finality incident.

  • A BlocksByRange answer with no block in the requested range counts as a failed request. Lean: crates/net/p2p/src/req_resp/handlers.rs:943-953. Beacon: handlers.rs:2905-2913.
  • The range session's cursor only moves when a batch delivers blocks (RangeSyncState::complete_batch, crates/net/p2p/src/lib.rs:865-867). Across a span a whole batch long with no block on the chain, range sync therefore never advances.
  • The honest peers asked for that span cool down. After three such answers in a row they become suspects (SUSPECT_AFTER_FAILURES, crates/net/p2p/src/peer_heads.rs), and their claims stop counting towards the network head.
  • The node can then read as synced while it is still behind, and only the parent lookups of newer gossip blocks fill the gap.

The trade-off is stated in docs/spec_deviations.md (the stall-window bullet of the sync-gate section). It was discussed in rounds seven, eight, eleven and thirteen of lambdaclass/ethlambda#791.

Why it is out of that PR's scope.

  • main already stops at such a span. Its lean handler fails an empty answer and returns before complete_batch (crates/net/p2p/src/req_resp/handlers.rs:817-821 on main), so its cursor does not move either.
  • Excusing empty answers in place was tried and reverted in lambdaclass/ethlambda#791. A peer claiming a high head was then excused on every batch below it, and took a batch on every Status it sent.
  • The fix is a change to range sync itself, not to the sync gate.

What a fix could look like.

  • Advance the cursor: when a peer whose Status head is past the span answers it empty, move the cursor past it.
  • Remember the skip: keep the skipped span and who answered it.
  • Check it with the next batch: use the parent link HeadWatch::note_delivery already uses. If the next batch's first block names, as its parent, the last block delivered below the span, the span was empty and the peer is credited.
  • Otherwise: re-ask the span from another peer, and count a failure against the peer that answered it empty.
主要言語
Rust
スター
86
フォーク
34
平均マージ
9日 20時間
マージ済み PR(30日)
77

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

lambdaclass/ethlambda のほかの issue

lambdaclass/ethlambda の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。