Range sync: step past a span with no blocks instead of failing the peer that serves it

Aperta
#812 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 6 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start with RangeSyncState::complete_batch in crates/net/p2p/src/lib.rs and the Lean and Beacon BlocksByRange handlers named in the issue. Read the stall-window note in docs/spec_deviations.md and the linked discussion in lambdaclass/ethlambda#791 to understand the prior attempt. A fix should advance across empty spans, verify skips using the next batch's parent link, and retry or count a failure when that check does not match.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem. Range sync cannot pass a stretch of slots with no block on the chain, such as a long run of missed proposals during a non-finality incident.

  • A BlocksByRange answer with no block in the requested range counts as a failed request. Lean: crates/net/p2p/src/req_resp/handlers.rs:943-953. Beacon: handlers.rs:2905-2913.
  • The range session's cursor only moves when a batch delivers blocks (RangeSyncState::complete_batch, crates/net/p2p/src/lib.rs:865-867). Across a span a whole batch long with no block on the chain, range sync therefore never advances.
  • The honest peers asked for that span cool down. After three such answers in a row they become suspects (SUSPECT_AFTER_FAILURES, crates/net/p2p/src/peer_heads.rs), and their claims stop counting towards the network head.
  • The node can then read as synced while it is still behind, and only the parent lookups of newer gossip blocks fill the gap.

The trade-off is stated in docs/spec_deviations.md (the stall-window bullet of the sync-gate section). It was discussed in rounds seven, eight, eleven and thirteen of lambdaclass/ethlambda#791.

Why it is out of that PR's scope.

  • main already stops at such a span. Its lean handler fails an empty answer and returns before complete_batch (crates/net/p2p/src/req_resp/handlers.rs:817-821 on main), so its cursor does not move either.
  • Excusing empty answers in place was tried and reverted in lambdaclass/ethlambda#791. A peer claiming a high head was then excused on every batch below it, and took a batch on every Status it sent.
  • The fix is a change to range sync itself, not to the sync gate.

What a fix could look like.

  • Advance the cursor: when a peer whose Status head is past the span answers it empty, move the cursor past it.
  • Remember the skip: keep the skipped span and who answered it.
  • Check it with the next batch: use the parent link HeadWatch::note_delivery already uses. If the next batch's first block names, as its parent, the last block delivered below the span, the span was empty and the peer is credited.
  • Otherwise: re-ask the span from another peer, and count a failure against the peer that answered it empty.
Lingua principale
Rust
Stelle
86
Fork
34
Merge medio
9g 20h
PR unite (30g)
77

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di lambdaclass/ethlambda

Tutte le issue di lambdaclass/ethlambda

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.