Unexpected handling of lines with less than 100 characters
還沒有人認領這個 Issue。
評估
研究方向
使用報告中所示的 google-java-format-1.9-all-deps.jar 命令列呼叫,透過 test.java 重現此問題,並比較變更前、變更後及預期的輸出。追蹤 formatter 對多行 SQL 字串的處理行為;完成標準是只有過長的行會被分割,而其他較短的行保留其原始格式。
由索引模型根據 Issue 內容生成。
描述
I have some quite large sql multiline string and when one line is over 100 characters it will re-format it onto 2 lines. While I believe this is the correct behaviour to split this long line, it also re-formats all of the other lines of the String which I don't think should happen as they are under 100 characters long, therefore I think this is a bug.
NB: Because of https://github.com/google/google-java-format/issues/566 you can only see this happening using the jar on the command line as per the example below:
before - unformatted file:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x=1;if(x==1){x=2;}else{x=3;}
}
}
apply google java formatting:
/tmp $ java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)
/tmp $ cksum ~/lib/google-java-format-1.9-all-deps.jar
2002751029 3404610 ~/lib/google-java-format-1.9-all-deps.jar
/tmp $ java -jar ~/lib/google-java-format-1.9-all-deps.jar ./test.java
after - formatted by google java formatter:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, l.some_really_long_column_name AS"
+ " some_really_looooooooooooooooooooong_column_name, customer_id AS"
+ " customer_id, customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
Expected - this is what I think google java formatter should do:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name "
+ "AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
- 主要語言
- Java
- 星號
- 6.2k
- 分支
- 936
- 平均合併
- 6 分鐘
- 30 天內合併 PR
- 3
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
google/google-java-format 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
google/google-java-format#1094 · 1 則留言 ·
-
難度 5/5 一週以上 新手友好度 15/100
google/google-java-format#1450 · 1 個 reaction ·
-
難度 4/5 3-5 天 新手友好度 55/100
google/google-java-format#1439 · 1 則留言 ·
-
難度 3/5 1-2 天 新手友好度 62/100
google/google-java-format#1436 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 48/100
google/google-java-format#1428 · 4 則留言 ·
查看 google/google-java-format 的全部 Issue
相似的 Issue
-
area/plugin
難度 2/5 1-3 小時 新手友好度 75/100
kestra-io/plugin-kestra#190 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
apache/rocketmq-dashboard#5064 ·