Unexpected handling of lines with less than 100 characters
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Reproduce el problema con test.java utilizando la invocación de línea de comandos de google-java-format-1.9-all-deps.jar mostrada en el informe, comparando la salida anterior, posterior y esperada. Rastrea el comportamiento del formateador para las cadenas SQL multilínea; se considera terminado cuando solo se divide la línea demasiado larga, mientras que las demás líneas más cortas conservan su formato original.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I have some quite large sql multiline string and when one line is over 100 characters it will re-format it onto 2 lines. While I believe this is the correct behaviour to split this long line, it also re-formats all of the other lines of the String which I don't think should happen as they are under 100 characters long, therefore I think this is a bug.
NB: Because of https://github.com/google/google-java-format/issues/566 you can only see this happening using the jar on the command line as per the example below:
before - unformatted file:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x=1;if(x==1){x=2;}else{x=3;}
}
}
apply google java formatting:
/tmp $ java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)
/tmp $ cksum ~/lib/google-java-format-1.9-all-deps.jar
2002751029 3404610 ~/lib/google-java-format-1.9-all-deps.jar
/tmp $ java -jar ~/lib/google-java-format-1.9-all-deps.jar ./test.java
after - formatted by google java formatter:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, l.some_really_long_column_name AS"
+ " some_really_looooooooooooooooooooong_column_name, customer_id AS"
+ " customer_id, customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
Expected - this is what I think google java formatter should do:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name "
+ "AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
- Lenguaje dominante
- Java
- Estrellas
- 6.2k
- Forks
- 936
- Merge medio
- 6 min
- PR fusionados (30 d)
- 3
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de google/google-java-format
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
google/google-java-format#1094 · 1 comentario ·
-
Complementary Teamups Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 15/100
google/google-java-format#1450 · 1 reacción ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
google/google-java-format#1439 · 1 comentario ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 62/100
google/google-java-format#1436 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
google/google-java-format#1428 · 4 comentarios ·
Todos los issues de google/google-java-format
Issues similares
-
executions.Query — startDate and timeRange filters are sent with inverted comparison operators Abiertoarea/plugin
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
kestra-io/plugin-kestra#190 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Add canonical URLs and a sitemap Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
apache/rocketmq-dashboard#5064 ·