Unexpected handling of lines with less than 100 characters
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 45/100
Piste de recherche
Reproduisez le problème avec test.java en utilisant l’invocation en ligne de commande de google-java-format-1.9-all-deps.jar indiquée dans le rapport, en comparant les sorties avant, après et attendue. Suivez le comportement du formateur pour les chaînes SQL multilignes ; le travail est terminé lorsque seule la ligne trop longue est divisée, tandis que les autres lignes plus courtes conservent leur formatage d’origine.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
I have some quite large sql multiline string and when one line is over 100 characters it will re-format it onto 2 lines. While I believe this is the correct behaviour to split this long line, it also re-formats all of the other lines of the String which I don't think should happen as they are under 100 characters long, therefore I think this is a bug.
NB: Because of https://github.com/google/google-java-format/issues/566 you can only see this happening using the jar on the command line as per the example below:
before - unformatted file:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x=1;if(x==1){x=2;}else{x=3;}
}
}
apply google java formatting:
/tmp $ java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)
/tmp $ cksum ~/lib/google-java-format-1.9-all-deps.jar
2002751029 3404610 ~/lib/google-java-format-1.9-all-deps.jar
/tmp $ java -jar ~/lib/google-java-format-1.9-all-deps.jar ./test.java
after - formatted by google java formatter:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, customer_id AS customer_id, "
+ " customer_id AS customer_id, l.some_really_long_column_name AS"
+ " some_really_looooooooooooooooooooong_column_name, customer_id AS"
+ " customer_id, customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
Expected - this is what I think google java formatter should do:
package x;
public class test {
static final String MY_SQL_QUERY =
"SELECT "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, "
+ " l.some_really_long_column_name "
+ "AS some_really_looooooooooooooooooooong_column_name, "
+ " customer_id AS customer_id, "
+ " customer_id AS customer_id, ";
public test() {
int x = 1;
if (x == 1) {
x = 2;
} else {
x = 3;
}
}
}
- Langage dominant
- Java
- Étoiles
- 6.2k
- Forks
- 936
- Merge moyen
- 6 min
- PR mergées (30 j)
- 3
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de google/google-java-format
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
google/google-java-format#1094 · 1 commentaire ·
-
Complementary Teamups Ouverte
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 15/100
google/google-java-format#1450 · 1 réaction ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 55/100
google/google-java-format#1439 · 1 commentaire ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 62/100
google/google-java-format#1436 · 2 commentaires ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 48/100
google/google-java-format#1428 · 4 commentaires ·
Toutes les issues de google/google-java-format
Issues similaires
-
executions.Query — startDate and timeRange filters are sent with inverted comparison operators Ouvertearea/plugin
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
kestra-io/plugin-kestra#190 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
Add canonical URLs and a sitemap Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
apache/rocketmq-dashboard#5064 ·