Queue never retries with a smaller batch after HTTP 413; the whole batch is dropped after the max attempts
維護者通常 6 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with src/Exceptionless/Queue/DefaultEventQueue.cs, especially the 413 handling and the loop exit at the cited lines; trace how the reduced batch size is used on the next iteration. Check src/Exceptionless/Extensions/FileStorageExtensions.cs to understand retry counts and cleanup. Reproduce with a fake ISubmissionClient that returns 413 above a chosen batch size; done when queued events are retried in smaller batches and only individually oversized events are discarded.
由索引模型根據 Issue 內容生成。
描述
In Exceptionless 6.2.0 (core Exceptionless package), when the server responds 413 (Request Entity Too Large), DefaultEventQueue.ProcessAsync lowers a local batchSize and logs "The event will be retried with a smaller batch size", but it then exits the loop immediately. The next run starts again at SubmissionBatchSize, so the smaller batch is never sent.
Where
- https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L58-L60 (
batchSizeis a local reset to_config.SubmissionBatchSizeon every run) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L86-L93 (413 handling reduces
batchSizeand setsdeleteBatch = false) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L113-L121 (
if (!deleteBatch || ...) break;exits before the reduced size is used) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L16-L25 and https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L96-L106 (each batch fetch increments the attempt count; files at
QueueMaxAttemptsare deleted)
What happens
- A batch of up to 50 events (the default
SubmissionBatchSize) gets a 413. batchSizebecomes 33, the batch is released, and the loop breaks.- About 10 seconds later the timer runs
ProcessAsyncagain, which starts at 50 again and resends the same oversized batch. - Each attempt increments the queued files' attempt counter. Once they reach
QueueMaxAttempts(default 3),CleanupQueueFilesdeletes them.
The result is that every event in the batch is discarded, including events that would have been accepted in a smaller batch. A 413 also does not suspend processing, so the oversized request is resent on every timer tick until the events are deleted.
Expected
After a 413, the queue retries the same events with progressively smaller batches (down to 1). Only an event that is too large on its own is discarded.
Steps to reproduce
- Use a submission client (or a test
ISubmissionClient) that returns 413 for any request with more than N events. - Queue more than N events and call
ProcessQueueAsync()repeatedly. - Every request contains
SubmissionBatchSizeevents. After 3 attempts the events are removed from the queue without being sent.
With the 6.2.0 package, a fake ISubmissionClient that returns 413 for more than 10 events, and 50 queued events, five calls to ProcessQueueAsync() send requests of [50, 50, 50] and then nothing: no smaller batch is ever tried and all 50 events are gone.
Suggested fix
Keep processing in the same run after a 413 (do not break when the batch was released only to shrink it), and/or keep the reduced batch size in a field so later runs use it. Consider not counting a 413 retry against QueueMaxAttempts.
- 主要語言
- C#
- 星號
- 573
- 分支
- 143
- 平均合併
- 5 天 9 小時
- 30 天內合併 PR
- 1
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
exceptionless/Exceptionless.Net 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 86/100
exceptionless/Exceptionless.Net#391 ·
維護者通常 6 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
exceptionless/Exceptionless.Net#390 ·
維護者通常 6 天內回覆
-
bug
難度 1/5 1-3 小時 新手友好度 88/100
exceptionless/Exceptionless.Net#387 ·
維護者通常 6 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
exceptionless/Exceptionless.Net#386 ·
維護者通常 6 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 35/100
exceptionless/Exceptionless.Net#389 ·
維護者通常 6 天內回覆
查看 exceptionless/Exceptionless.Net 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 1/5 1-3 小時 新手友好度 89/100
getsentry/sentry-dotnet#5833 · 1 則留言 ·
維護者通常 1 天內回覆
-
area: core priority: low type: bug
難度 2/5 1-3 小時 新手友好度 74/100
RicoSuter/Namotion.Interceptor#863 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
bitfoundation/bitplatform#14428 · 1 則留言 ·
維護者通常 1 天內回覆
-
area-cli
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆