Queue never retries with a smaller batch after HTTP 413; the whole batch is dropped after the max attempts
メンテナーはふだん 6 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 72/100
調査の方向性
Start with src/Exceptionless/Queue/DefaultEventQueue.cs, especially the 413 handling and the loop exit at the cited lines; trace how the reduced batch size is used on the next iteration. Check src/Exceptionless/Extensions/FileStorageExtensions.cs to understand retry counts and cleanup. Reproduce with a fake ISubmissionClient that returns 413 above a chosen batch size; done when queued events are retried in smaller batches and only individually oversized events are discarded.
索引モデルが issue の本文から書いたものです。
説明
In Exceptionless 6.2.0 (core Exceptionless package), when the server responds 413 (Request Entity Too Large), DefaultEventQueue.ProcessAsync lowers a local batchSize and logs "The event will be retried with a smaller batch size", but it then exits the loop immediately. The next run starts again at SubmissionBatchSize, so the smaller batch is never sent.
Where
- https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L58-L60 (
batchSizeis a local reset to_config.SubmissionBatchSizeon every run) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L86-L93 (413 handling reduces
batchSizeand setsdeleteBatch = false) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L113-L121 (
if (!deleteBatch || ...) break;exits before the reduced size is used) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L16-L25 and https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L96-L106 (each batch fetch increments the attempt count; files at
QueueMaxAttemptsare deleted)
What happens
- A batch of up to 50 events (the default
SubmissionBatchSize) gets a 413. batchSizebecomes 33, the batch is released, and the loop breaks.- About 10 seconds later the timer runs
ProcessAsyncagain, which starts at 50 again and resends the same oversized batch. - Each attempt increments the queued files' attempt counter. Once they reach
QueueMaxAttempts(default 3),CleanupQueueFilesdeletes them.
The result is that every event in the batch is discarded, including events that would have been accepted in a smaller batch. A 413 also does not suspend processing, so the oversized request is resent on every timer tick until the events are deleted.
Expected
After a 413, the queue retries the same events with progressively smaller batches (down to 1). Only an event that is too large on its own is discarded.
Steps to reproduce
- Use a submission client (or a test
ISubmissionClient) that returns 413 for any request with more than N events. - Queue more than N events and call
ProcessQueueAsync()repeatedly. - Every request contains
SubmissionBatchSizeevents. After 3 attempts the events are removed from the queue without being sent.
With the 6.2.0 package, a fake ISubmissionClient that returns 413 for more than 10 events, and 50 queued events, five calls to ProcessQueueAsync() send requests of [50, 50, 50] and then nothing: no smaller batch is ever tried and all 50 events are gone.
Suggested fix
Keep processing in the same run after a 413 (do not break when the batch was released only to shrink it), and/or keep the reduced batch size in a field so later runs use it. Consider not counting a 413 retry against QueueMaxAttempts.
- 主要言語
- C#
- スター
- 573
- フォーク
- 143
- 平均マージ
- 5日 9時間
- マージ済み PR(30日)
- 1
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
exceptionless/Exceptionless.Net のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
exceptionless/Exceptionless.Net#391 ·
メンテナーはふだん 6 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
exceptionless/Exceptionless.Net#390 ·
メンテナーはふだん 6 日以内に返信
-
bug
難易度 1/5 1〜3時間 初心者へのやさしさ 88/100
exceptionless/Exceptionless.Net#387 ·
メンテナーはふだん 6 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
exceptionless/Exceptionless.Net#386 ·
メンテナーはふだん 6 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 35/100
exceptionless/Exceptionless.Net#389 ·
メンテナーはふだん 6 日以内に返信
exceptionless/Exceptionless.Net の issue をすべて見る
似ている issue
-
area: core priority: low type: bug
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
RicoSuter/Namotion.Interceptor#863 ·
メンテナーはふだん 1 日以内に返信
-
area-cli
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
0.3.0
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
メンテナーはふだん 2 日以内に返信
-
[Bug] Decompression leaves metadata that makes recompression throw and corrupt the content typeオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
BrighterCommand/Brighter#4683 ·
メンテナーはふだん 1 日以内に返信