Queue never retries with a smaller batch after HTTP 413; the whole batch is dropped after the max attempts
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
Direzione di ricerca
Start with src/Exceptionless/Queue/DefaultEventQueue.cs, especially the 413 handling and the loop exit at the cited lines; trace how the reduced batch size is used on the next iteration. Check src/Exceptionless/Extensions/FileStorageExtensions.cs to understand retry counts and cleanup. Reproduce with a fake ISubmissionClient that returns 413 above a chosen batch size; done when queued events are retried in smaller batches and only individually oversized events are discarded.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
In Exceptionless 6.2.0 (core Exceptionless package), when the server responds 413 (Request Entity Too Large), DefaultEventQueue.ProcessAsync lowers a local batchSize and logs "The event will be retried with a smaller batch size", but it then exits the loop immediately. The next run starts again at SubmissionBatchSize, so the smaller batch is never sent.
Where
- https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L58-L60 (
batchSizeis a local reset to_config.SubmissionBatchSizeon every run) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L86-L93 (413 handling reduces
batchSizeand setsdeleteBatch = false) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Queue/DefaultEventQueue.cs#L113-L121 (
if (!deleteBatch || ...) break;exits before the reduced size is used) - https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L16-L25 and https://github.com/exceptionless/Exceptionless.Net/blob/5792f00d175f94a35fe0559c8e9999234a8163be/src/Exceptionless/Extensions/FileStorageExtensions.cs#L96-L106 (each batch fetch increments the attempt count; files at
QueueMaxAttemptsare deleted)
What happens
- A batch of up to 50 events (the default
SubmissionBatchSize) gets a 413. batchSizebecomes 33, the batch is released, and the loop breaks.- About 10 seconds later the timer runs
ProcessAsyncagain, which starts at 50 again and resends the same oversized batch. - Each attempt increments the queued files' attempt counter. Once they reach
QueueMaxAttempts(default 3),CleanupQueueFilesdeletes them.
The result is that every event in the batch is discarded, including events that would have been accepted in a smaller batch. A 413 also does not suspend processing, so the oversized request is resent on every timer tick until the events are deleted.
Expected
After a 413, the queue retries the same events with progressively smaller batches (down to 1). Only an event that is too large on its own is discarded.
Steps to reproduce
- Use a submission client (or a test
ISubmissionClient) that returns 413 for any request with more than N events. - Queue more than N events and call
ProcessQueueAsync()repeatedly. - Every request contains
SubmissionBatchSizeevents. After 3 attempts the events are removed from the queue without being sent.
With the 6.2.0 package, a fake ISubmissionClient that returns 413 for more than 10 events, and 50 queued events, five calls to ProcessQueueAsync() send requests of [50, 50, 50] and then nothing: no smaller batch is ever tried and all 50 events are gone.
Suggested fix
Keep processing in the same run after a 413 (do not break when the batch was released only to shrink it), and/or keep the reduced batch size in a field so later runs use it. Consider not counting a 413 retry against QueueMaxAttempts.
- Lingua principale
- C#
- Stelle
- 573
- Fork
- 143
- Merge medio
- 5g 9h
- PR unite (30g)
- 1
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di exceptionless/Exceptionless.Net
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
exceptionless/Exceptionless.Net#391 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
exceptionless/Exceptionless.Net#390 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 1/5 1-3 ore Idoneità per principianti 88/100
exceptionless/Exceptionless.Net#387 ·
I maintainer di solito rispondono entro 6 giorni
-
AWS Lambda detection never matches because the environment variable name has a trailing spaceApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
exceptionless/Exceptionless.Net#386 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 35/100
exceptionless/Exceptionless.Net#389 ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di exceptionless/Exceptionless.Net
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 89/100
getsentry/sentry-dotnet#5833 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area: core priority: low type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
RicoSuter/Namotion.Interceptor#863 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
bitfoundation/bitplatform#14428 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area-cli
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno