Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Permission to file upstream: tend's CI poll waits out an environment-approval check it cannot advance

未關閉
  • 哪裡不對？
#846 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
github-actions, graphql, python
領域
ci-cd

研究方向

This request targets max-sixty/tend rather than the dormouse codebase. Read tend's poll_pr_checks.py, especially reduce_rollup and _settle, then inspect how approval() handles unverified checks. Add coverage for a WAITING check alongside green checks and verify that polling returns without waiting for the deadline.

由索引模型根據 Issue 內容生成。

描述

Asking before filing, per the repo policy on cross-repo issues.

What I'd file at max-sixty/tend: poll_pr_checks.py treats a check that is waiting on a GitHub environment approval as ordinary pending, so it polls until its own time limit. Here that check is Hosted PR preview → deploy, gated by the hosted-preview environment, and it never moves until a maintainer approves it. Today this costs about 10 minutes of runner time per review. Once tend releases max-sixty/tend#1448 (merged 2026-09-29, after 0.3.4), the poll no longer stops at 9 minutes. It waits until the session deadline, so every tend-review on a PR that touches hosted/ would stay parked for most of its job timeout.

What happened here

In the last 24 hours, 9 tend-review sessions used up the full poll on deploy and then reported it as "still pending, unverified": #814, #815, #817, #818, #819, #823, #832, #840, and #842 (the #842 session took 21 minutes). The GitHub API reports the check as status: waiting and conclusion: null, for example deploy on #842 at 924adc2d. The reviews themselves were right. They approved on the finished checks and said plainly that deploy was unverified, so the only cost is wall-clock time. #1448 turns that cost into hours.

The gap upstream

On tend main at bb5ca166, reduce_rollup counts every CheckRun whose status != "COMPLETED" as pending. _settle then keeps polling while anything is pending, and its docstring already names this case as one that only the deadline ends: "a job waiting on an environment approval — would otherwise hold the wait until the session is killed". GraphQL gives this state its own CheckStatusState value, WAITING, so the poll can recognize it on the first read.

Proposed fix

In reduce_rollup, report a CheckRun with status == "WAITING" as not settled, and don't count it as pending. That means listing it under unverified (or a new gated bucket) with a note like "waiting on an environment approval". _settle then returns as soon as everything else has finished. approval() already handles unverified by approving and naming the check, which is what the sessions here did by hand. A test would build a rollup where one check is WAITING and the rest are green, and assert that the poll returns without waiting for the deadline.

I'll file it at max-sixty/tend once a maintainer gives permission here.

Session evidence

tend-review runs whose final summaries record deploy as still pending when the poll ran out: 36448096828 (#814), 36448133617 (#815), 36451630623 (#817), 36451659386 (#818), 36462597788 (#819), 36475943580 (#823), 36498908465 (#832), 36536769467 (#840), 36572097896 (#842). The waiting runs of Hosted PR preview that are still queued go back to 2026-09-24 (gh api 'repos/diffplug/dormouse/actions/runs?status=waiting').

主要語言
TypeScript
星號
5
分支
1
平均合併
14 小時 43 分鐘
30 天內合併 PR
289

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

diffplug/dormouse 的其他 Issue

查看 diffplug/dormouse 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。