Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Permission to file upstream: tend's CI poll waits out an environment-approval check it cannot advance

Aberta
  • Algo errado?
#846 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github-actions, graphql, python
Domínio
ci-cd

Direção de pesquisa

This request targets max-sixty/tend rather than the dormouse codebase. Read tend's poll_pr_checks.py, especially reduce_rollup and _settle, then inspect how approval() handles unverified checks. Add coverage for a WAITING check alongside green checks and verify that polling returns without waiting for the deadline.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Asking before filing, per the repo policy on cross-repo issues.

What I'd file at max-sixty/tend: poll_pr_checks.py treats a check that is waiting on a GitHub environment approval as ordinary pending, so it polls until its own time limit. Here that check is Hosted PR preview → deploy, gated by the hosted-preview environment, and it never moves until a maintainer approves it. Today this costs about 10 minutes of runner time per review. Once tend releases max-sixty/tend#1448 (merged 2026-09-29, after 0.3.4), the poll no longer stops at 9 minutes. It waits until the session deadline, so every tend-review on a PR that touches hosted/ would stay parked for most of its job timeout.

What happened here

In the last 24 hours, 9 tend-review sessions used up the full poll on deploy and then reported it as "still pending, unverified": #814, #815, #817, #818, #819, #823, #832, #840, and #842 (the #842 session took 21 minutes). The GitHub API reports the check as status: waiting and conclusion: null, for example deploy on #842 at 924adc2d. The reviews themselves were right. They approved on the finished checks and said plainly that deploy was unverified, so the only cost is wall-clock time. #1448 turns that cost into hours.

The gap upstream

On tend main at bb5ca166, reduce_rollup counts every CheckRun whose status != "COMPLETED" as pending. _settle then keeps polling while anything is pending, and its docstring already names this case as one that only the deadline ends: "a job waiting on an environment approval — would otherwise hold the wait until the session is killed". GraphQL gives this state its own CheckStatusState value, WAITING, so the poll can recognize it on the first read.

Proposed fix

In reduce_rollup, report a CheckRun with status == "WAITING" as not settled, and don't count it as pending. That means listing it under unverified (or a new gated bucket) with a note like "waiting on an environment approval". _settle then returns as soon as everything else has finished. approval() already handles unverified by approving and naming the check, which is what the sessions here did by hand. A test would build a rollup where one check is WAITING and the rest are green, and assert that the poll returns without waiting for the deadline.

I'll file it at max-sixty/tend once a maintainer gives permission here.

Session evidence

tend-review runs whose final summaries record deploy as still pending when the poll ran out: 36448096828 (#814), 36448133617 (#815), 36451630623 (#817), 36451659386 (#818), 36462597788 (#819), 36475943580 (#823), 36498908465 (#832), 36536769467 (#840), 36572097896 (#842). The waiting runs of Hosted PR preview that are still queued go back to 2026-09-24 (gh api 'repos/diffplug/dormouse/actions/runs?status=waiting').

Linguagem predominante
TypeScript
Estrelas
5
Forks
1
Merge médio
14h 43min
PRs com merge (30d)
289

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de diffplug/dormouse

Todas as issues de diffplug/dormouse

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.