Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Permission to file upstream: tend's CI poll waits out an environment-approval check it cannot advance

Ouverte
  • Quelque chose ne va pas ?
#846 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
github-actions, graphql, python
Domaine
ci-cd

Piste de recherche

This request targets max-sixty/tend rather than the dormouse codebase. Read tend's poll_pr_checks.py, especially reduce_rollup and _settle, then inspect how approval() handles unverified checks. Add coverage for a WAITING check alongside green checks and verify that polling returns without waiting for the deadline.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Asking before filing, per the repo policy on cross-repo issues.

What I'd file at max-sixty/tend: poll_pr_checks.py treats a check that is waiting on a GitHub environment approval as ordinary pending, so it polls until its own time limit. Here that check is Hosted PR preview → deploy, gated by the hosted-preview environment, and it never moves until a maintainer approves it. Today this costs about 10 minutes of runner time per review. Once tend releases max-sixty/tend#1448 (merged 2026-09-29, after 0.3.4), the poll no longer stops at 9 minutes. It waits until the session deadline, so every tend-review on a PR that touches hosted/ would stay parked for most of its job timeout.

What happened here

In the last 24 hours, 9 tend-review sessions used up the full poll on deploy and then reported it as "still pending, unverified": #814, #815, #817, #818, #819, #823, #832, #840, and #842 (the #842 session took 21 minutes). The GitHub API reports the check as status: waiting and conclusion: null, for example deploy on #842 at 924adc2d. The reviews themselves were right. They approved on the finished checks and said plainly that deploy was unverified, so the only cost is wall-clock time. #1448 turns that cost into hours.

The gap upstream

On tend main at bb5ca166, reduce_rollup counts every CheckRun whose status != "COMPLETED" as pending. _settle then keeps polling while anything is pending, and its docstring already names this case as one that only the deadline ends: "a job waiting on an environment approval — would otherwise hold the wait until the session is killed". GraphQL gives this state its own CheckStatusState value, WAITING, so the poll can recognize it on the first read.

Proposed fix

In reduce_rollup, report a CheckRun with status == "WAITING" as not settled, and don't count it as pending. That means listing it under unverified (or a new gated bucket) with a note like "waiting on an environment approval". _settle then returns as soon as everything else has finished. approval() already handles unverified by approving and naming the check, which is what the sessions here did by hand. A test would build a rollup where one check is WAITING and the rest are green, and assert that the poll returns without waiting for the deadline.

I'll file it at max-sixty/tend once a maintainer gives permission here.

Session evidence

tend-review runs whose final summaries record deploy as still pending when the poll ran out: 36448096828 (#814), 36448133617 (#815), 36451630623 (#817), 36451659386 (#818), 36462597788 (#819), 36475943580 (#823), 36498908465 (#832), 36536769467 (#840), 36572097896 (#842). The waiting runs of Hosted PR preview that are still queued go back to 2026-09-24 (gh api 'repos/diffplug/dormouse/actions/runs?status=waiting').

Langage dominant
TypeScript
Étoiles
5
Forks
1
Merge moyen
14 h 43 min
PR mergées (30 j)
289

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de diffplug/dormouse

Toutes les issues de diffplug/dormouse

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.