Upgrade jsdom 24.x to 31.x

未關閉
#37 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
52/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
javascript, node.js

研究方向

Start by reading package.json and the four test files listed in the issue, then run npm install, npm test, and npm run lint to capture the current failure. Check the Node engine and module loading behavior for jsdom 31, then use the test output to guide the update. Done when jsdom is on the current major, the suite and lint pass, and PR #21 is closed.

由索引模型根據 Issue 內容生成。

描述

dependencies help wanted severity: low

Summary

jsdom is pinned at ^24.1.0 (resolves to 24.1.3); the latest is 31.0.0. All four test files load it directly, and the automated attempts to move it (PR #21 to 28.1.0 and earlier ones) failed CI.

Where

  • package.json:17
  • tests/unit/utils.test.js:1, tests/unit/pieces.test.js:1, tests/unit/game-moves.test.js:1, tests/integration/game-flow.test.js:1

Details

The CI logs for the failed PRs have expired, so the cause is unconfirmed. Likely suspects are the Node engine floor of newer jsdom and require() of a package with ESM-only dependencies under "type": "module" (package.json:5).

Suggested fix

After #36, bump to ^31, run the suite locally to capture the failure, fix the test bootstrap, and close PR #21.

Acceptance criteria

  • jsdom is on the current major and tests pass
  • PR #21 is closed

Getting started

  • Relevant files: package.json, tests/
  • How to run tests: npm install, then npm test and npm run lint
  • Related docs: docs/ARCHITECTURE.md, .github/CONTRIBUTING.md

Filed by repo-audit/full-audit at 8a2c86c. Severity: low. Effort: M. audit-key: dependencies|package.json|jsdom

主要語言
JavaScript
星號
4
分支
2
PR 合併指標
30 天內沒有已合併 PR

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/Static_Chess 的其他 Issue

查看 TMHSDigital/Static_Chess 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。