Upgrade jsdom 24.x to 31.x
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 52/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, node.js
- 领域
- build-system, testing
调研方向
Start by reading package.json and the four test files listed in the issue, then run npm install, npm test, and npm run lint to capture the current failure. Check the Node engine and module loading behavior for jsdom 31, then use the test output to guide the update. Done when jsdom is on the current major, the suite and lint pass, and PR #21 is closed.
由索引模型根据 Issue 内容生成。
描述
Summary
jsdom is pinned at ^24.1.0 (resolves to 24.1.3); the latest is 31.0.0. All four test files load it directly, and the automated attempts to move it (PR #21 to 28.1.0 and earlier ones) failed CI.
Where
package.json:17tests/unit/utils.test.js:1,tests/unit/pieces.test.js:1,tests/unit/game-moves.test.js:1,tests/integration/game-flow.test.js:1
Details
The CI logs for the failed PRs have expired, so the cause is unconfirmed. Likely suspects are the Node engine floor of newer jsdom and require() of a package with ESM-only dependencies under "type": "module" (package.json:5).
Suggested fix
After #36, bump to ^31, run the suite locally to capture the failure, fix the test bootstrap, and close PR #21.
Acceptance criteria
-
jsdomis on the current major and tests pass - PR #21 is closed
Getting started
- Relevant files:
package.json,tests/ - How to run tests:
npm install, thennpm testandnpm run lint - Related docs:
docs/ARCHITECTURE.md,.github/CONTRIBUTING.md
Filed by repo-audit/full-audit at 8a2c86c. Severity: low. Effort: M. audit-key: dependencies|package.json|jsdom
- 主要语言
- JavaScript
- 星标
- 4
- 派生
- 2
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
TMHSDigital/Static_Chess 的其他 Issue
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/Static_Chess#53 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 72/100
TMHSDigital/Static_Chess#49 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 83/100
TMHSDigital/Static_Chess#48 ·
-
documentation severity: medium
难度 2/5 1-3 小时 新手友好度 78/100
TMHSDigital/Static_Chess#47 ·
-
documentation good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/Static_Chess#46 ·
查看 TMHSDigital/Static_Chess 的全部 Issue
相似的 Issue
-
good first issue tests
难度 1/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 90/100
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
TMHSDigital/Free-Game-Dev-Assets#301 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 79/100