Custom time controls

未關閉
#159 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
56/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
javascript
領域
frontend, game-dev

研究方向

Start with js/config.js and index.html to see how the existing presets populate #clock-select, then follow the selection handling in js/main.js and clock startup in js/clock.js. Read tests/unit/clock.test.js and run npm ci && npm test to understand current validation. Done when custom controls persist across reloads, invalid values cannot start the clock, and the tests cover the new behavior; bounds and PGN formatting still need decisions.

由索引模型根據 Issue 內容生成。

描述

enhancement help wanted severity: low

Summary

The clock offers only five fixed presets (1+0, 3+2, 5+0, 10+0, 15+10). Common controls such as 3+0, 5+3 or 30+0, and odds games, cannot be chosen.

Where

  • js/config.js:18-25 (TIME_CONTROLS)
  • index.html:166 (#clock-select)

Proposal

Add a "Custom..." option to #clock-select that shows two number inputs (minutes, increment seconds), validated and stored as custom:M+I in the time-control setting. Optionally, a per-side minutes field for odds games.

Who benefits

Players who want a longer game, or an odds game against a stronger friend.

Open questions

  • Bounds (e.g. 1 to 180 minutes, 0 to 60 seconds increment).
  • How a custom control is written to the PGN TimeControl tag.

Acceptance criteria

  • A custom control is kept across reloads and validated by validateSavedGame
  • Invalid input cannot start a clock
  • Tests in tests/unit/clock.test.js

Getting started

  • Relevant files: js/config.js, js/main.js, js/clock.js, index.html
  • How to run tests: npm ci && npm test

Filed by repo-audit/full-audit at 73cd279. Severity: low. Effort: M. audit-key: enhancement|js/config.js|TIME_CONTROLS

主要語言
JavaScript
星號
4
分支
2
平均合併
22 小時 16 分鐘
30 天內合併 PR
9

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/Static_Chess 的其他 Issue

查看 TMHSDigital/Static_Chess 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。