Scaffolded games break on pause MAIN MENU; template has drifted

未關閉
  • 哪裡不對？
#8 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript, vite
領域
game-dev

研究方向

Read games/_template/main.ts, scripts/new-game.mjs, shared/pause.ts and shared/scenes.ts, then compare the template with a shipped game's config.ts, scenes/MenuScene.ts and scenes/GameScene.ts. Run npm run new-game demo and check pause navigation and play recording; confirm the README documents scene keys and the acceptance criteria are met. Run npm run typecheck and npm run build.

由索引模型根據 Issue 內容生成。

描述

bug help wanted severity: medium

Summary

npm run new-game produces a game that no longer matches how any of the ten shipped games are built, and its pause menu has an option that leaves a blank canvas.

Where

  • games/_template/main.ts:19-78 (single scene keyed 'Main', wires PauseController)
  • shared/pause.ts:58 (scene.scene.start('Menu')), shared/scenes.ts:128-129 (keys 'Game', 'Menu')
  • scripts/new-game.mjs:31-41
  • README.md:203, README.md:217, README.md:321

Details

All ten games use config.ts, scenes/MenuScene.ts (via buildMenu), scenes/GameScene.ts and the shared ArcadeGameOverScene, with scene keys Menu, Game and GameOver that the shared modules hard-code. The template is one file with one scene and none of those keys. As a result:

  • Pause, MAIN MENU stops the only scene and starts nothing. This is from reading the code and Phaser's scene plugin; it was not run.
  • The template calls submitHighScore directly and never reaches recordPlay, so a scaffolded game records no plays or stats.
  • The registry entry has no thumbnail, and a game with no trophies is skipped by the Trophies panel and not required for the "play every game" trophy.
  • The README says pause is "already wired up" and that every game folder has config.ts and scenes/; the scene-key convention is not documented.

Steps to reproduce

  1. npm run new-game demo, then npm run dev.
  2. Open /GH-Arcade/games/demo/, press P, choose MAIN MENU.

Suggested fix

  • Rebuild games/_template/ in the real shape (config, Menu via buildMenu, Game, shared GameOver).
  • Export scene-key constants from shared/scenes.ts and use them in pause.ts; hide MAIN MENU when no Menu scene exists.
  • Have the scaffolder print the remaining manual steps (registry description and tags, thumbnail, trophies).
  • Add a short "Scene keys" note to the README toolkit section.

Acceptance criteria

  • A freshly scaffolded game has a menu, a game over screen and records plays
  • No pause menu option leaves a blank canvas
  • README describes the scene-key convention

Getting started

  • Relevant files: games/_template/main.ts, scripts/new-game.mjs, shared/pause.ts, shared/scenes.ts, README.md
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: bug|games/_template/main.ts|MainScene

主要語言
TypeScript
星號
3
分支
3
30 天內沒有已合併 PR

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

TMHSDigital/GH-Arcade 的其他 Issue

查看 TMHSDigital/GH-Arcade 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。