Scaffolded games break on pause MAIN MENU; template has drifted

Abierto
  • ¿Algo no está bien?
#8 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript, vite
Área
game-dev

Línea de trabajo

Read games/_template/main.ts, scripts/new-game.mjs, shared/pause.ts and shared/scenes.ts, then compare the template with a shipped game's config.ts, scenes/MenuScene.ts and scenes/GameScene.ts. Run npm run new-game demo and check pause navigation and play recording; confirm the README documents scene keys and the acceptance criteria are met. Run npm run typecheck and npm run build.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug help wanted severity: medium

Summary

npm run new-game produces a game that no longer matches how any of the ten shipped games are built, and its pause menu has an option that leaves a blank canvas.

Where

  • games/_template/main.ts:19-78 (single scene keyed 'Main', wires PauseController)
  • shared/pause.ts:58 (scene.scene.start('Menu')), shared/scenes.ts:128-129 (keys 'Game', 'Menu')
  • scripts/new-game.mjs:31-41
  • README.md:203, README.md:217, README.md:321

Details

All ten games use config.ts, scenes/MenuScene.ts (via buildMenu), scenes/GameScene.ts and the shared ArcadeGameOverScene, with scene keys Menu, Game and GameOver that the shared modules hard-code. The template is one file with one scene and none of those keys. As a result:

  • Pause, MAIN MENU stops the only scene and starts nothing. This is from reading the code and Phaser's scene plugin; it was not run.
  • The template calls submitHighScore directly and never reaches recordPlay, so a scaffolded game records no plays or stats.
  • The registry entry has no thumbnail, and a game with no trophies is skipped by the Trophies panel and not required for the "play every game" trophy.
  • The README says pause is "already wired up" and that every game folder has config.ts and scenes/; the scene-key convention is not documented.

Steps to reproduce

  1. npm run new-game demo, then npm run dev.
  2. Open /GH-Arcade/games/demo/, press P, choose MAIN MENU.

Suggested fix

  • Rebuild games/_template/ in the real shape (config, Menu via buildMenu, Game, shared GameOver).
  • Export scene-key constants from shared/scenes.ts and use them in pause.ts; hide MAIN MENU when no Menu scene exists.
  • Have the scaffolder print the remaining manual steps (registry description and tags, thumbnail, trophies).
  • Add a short "Scene keys" note to the README toolkit section.

Acceptance criteria

  • A freshly scaffolded game has a menu, a game over screen and records plays
  • No pause menu option leaves a blank canvas
  • README describes the scene-key convention

Getting started

  • Relevant files: games/_template/main.ts, scripts/new-game.mjs, shared/pause.ts, shared/scenes.ts, README.md
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: bug|games/_template/main.ts|MainScene

Lenguaje dominante
TypeScript
Estrellas
3
Forks
3
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/GH-Arcade

Todos los issues de TMHSDigital/GH-Arcade

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.