Runner sun, Snake bonus star and Stack previews allocate every frame
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 72/100
- Issue 類型
- 重構
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript
- 領域
- game-dev, performance
研究方向
Read the render paths in games/runner/scenes/GameScene.ts and games/snake/scenes/GameScene.ts, then inspect drawMini in games/stack/scenes/GameScene.ts. Compare the per-frame allocations with the suggested caching or reuse approaches in the issue. Run npm test and use npm run dev to check the three screens; done means all three paths avoid per-frame allocations while their visuals stay unchanged.
由索引模型根據 Issue 內容生成。
描述
Summary
Three render paths allocate new objects on every frame for values that do not change from frame to frame. Each one is small, but together they add steady garbage on phones.
Where
games/runner/scenes/GameScene.ts(render, the synthwave sun): each frame builds twoPhaser.Display.Colorobjects withValueToColorand interpolates a third for each of the 12 sun bands, although the band colors never change.games/snake/scenes/GameScene.ts(starPoints, called fromrenderwhile a bonus star is up): a new array of 10Phaser.Math.Vector2each frame.games/stack/scenes/GameScene.ts(drawMini): for the hold piece and every next-piece preview, each frame builds a cell array and four mapped arrays forMath.min/Math.max, although a piece type's preview layout never changes.
Details
Runner's sun, for example:
const c = Phaser.Display.Color.Interpolate.ColorWithColor(
Phaser.Display.Color.ValueToColor(NEON.yellow),
Phaser.Display.Color.ValueToColor(NEON.pink),
11,
i,
);
Impact
Low. This is extra minor-GC pressure for as long as each screen is up. It is the same class of cost as the items in #107.
Suggested fix
- Runner: compute the 12 band colors once into a module constant.
- Snake: reuse one points array and set its entries in place, or bake the star once (the rotation could then be the Image's rotation).
- Stack: cache each piece type's preview cells and offsets in a
Mapthe first time it is drawn.
Acceptance criteria
- None of the three paths allocates per frame.
- Visuals are unchanged.
Getting started
- Relevant files: the three scenes above
- How to run tests:
npm test; run a game withnpm run dev
Related: #107
Filed by repo-audit/fix-issues at b2a3ff6. Severity: low. Effort: S. audit-key: performance|games/runner/scenes/GameScene.ts|sun-colors
- 主要語言
- TypeScript
- 星號
- 3
- 分支
- 3
- 平均合併
- 10 小時 22 分鐘
- 30 天內合併 PR
- 6
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TMHSDigital/GH-Arcade 的其他 Issue
-
enhancement help wanted severity: low
難度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/GH-Arcade#139 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: medium
難度 4/5 3-5 天 新手友好度 56/100
TMHSDigital/GH-Arcade#127 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: medium
難度 4/5 3-5 天 新手友好度 48/100
TMHSDigital/GH-Arcade#126 · 1 則留言 ·
維護者通常 1 天內回覆
-
accessibility enhancement severity: low
難度 4/5 3-5 天 新手友好度 40/100
TMHSDigital/GH-Arcade#114 ·
維護者通常 1 天內回覆
-
enhancement severity: low
難度 4/5 3-5 天 新手友好度 35/100
TMHSDigital/GH-Arcade#113 ·
維護者通常 1 天內回覆
查看 TMHSDigital/GH-Arcade 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
難度 2/5 1-3 小時 新手友好度 76/100
openclaw/openclaw#203385 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
nwverse/persona#12800 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未關閉
難度 2/5 1-3 小時 新手友好度 62/100
microsoft/playwright#44289 ·
維護者通常 1 天內回覆
-
good first issue
難度 2/5 半天 新手友好度 65/100
維護者通常 1 天內回覆