Runner sun, Snake bonus star and Stack previews allocate every frame

未关闭
#141 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript

调研方向

Read the render paths in games/runner/scenes/GameScene.ts and games/snake/scenes/GameScene.ts, then inspect drawMini in games/stack/scenes/GameScene.ts. Compare the per-frame allocations with the suggested caching or reuse approaches in the issue. Run npm test and use npm run dev to check the three screens; done means all three paths avoid per-frame allocations while their visuals stay unchanged.

由索引模型根据 Issue 内容生成。

描述

good first issue performance severity: low

Summary

Three render paths allocate new objects on every frame for values that do not change from frame to frame. Each one is small, but together they add steady garbage on phones.

Where

  • games/runner/scenes/GameScene.ts (render, the synthwave sun): each frame builds two Phaser.Display.Color objects with ValueToColor and interpolates a third for each of the 12 sun bands, although the band colors never change.
  • games/snake/scenes/GameScene.ts (starPoints, called from render while a bonus star is up): a new array of 10 Phaser.Math.Vector2 each frame.
  • games/stack/scenes/GameScene.ts (drawMini): for the hold piece and every next-piece preview, each frame builds a cell array and four mapped arrays for Math.min / Math.max, although a piece type's preview layout never changes.

Details

Runner's sun, for example:

const c = Phaser.Display.Color.Interpolate.ColorWithColor(
  Phaser.Display.Color.ValueToColor(NEON.yellow),
  Phaser.Display.Color.ValueToColor(NEON.pink),
  11,
  i,
);

Impact

Low. This is extra minor-GC pressure for as long as each screen is up. It is the same class of cost as the items in #107.

Suggested fix

  • Runner: compute the 12 band colors once into a module constant.
  • Snake: reuse one points array and set its entries in place, or bake the star once (the rotation could then be the Image's rotation).
  • Stack: cache each piece type's preview cells and offsets in a Map the first time it is drawn.

Acceptance criteria

  • None of the three paths allocates per frame.
  • Visuals are unchanged.

Getting started

  • Relevant files: the three scenes above
  • How to run tests: npm test; run a game with npm run dev

Related: #107


Filed by repo-audit/fix-issues at b2a3ff6. Severity: low. Effort: S. audit-key: performance|games/runner/scenes/GameScene.ts|sun-colors

主要语言
TypeScript
星标
3
派生
3
平均合并
10 小时 22 分钟
30 天内合并 PR
6

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/GH-Arcade 的其他 Issue

查看 TMHSDigital/GH-Arcade 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。