Infra: pin lycheeverse/lychee-action to v2.9.0 (optional)

未關閉
#618 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
1/5
預估耗時
1 小時以內
新手友好度
25/100
Issue 類型
重構
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
github-actions, yaml
領域
ci-cd

研究方向

The workflow call site is .github/workflows/build-docs.yml, in the validate job. Read the lychee step and choose whether to keep the floating @v2 tag or pin it to @v2.9.0; the issue says both currently resolve to the same commit. If you pin it, run the validate job on a PR and confirm the lychee step succeeds and reports the expected version.

由索引模型根據 Issue 內容生成。

描述

dependencies Infrastructure

Summary

Pin lycheeverse/lychee-action from the floating @v2 to @v2.9.0 (latest release). This is optional. @v2 already resolves to the same commit as @v2.9.0, so this is about making the version explicit, not about picking up a new release.

What changed upstream (v2.8.0 → v2.9.0)

  • Default lychee binary bumped from v0.23.0 to v0.24.2. Upstream lychee 0.24.x changed the archive layout, and the action now detects it automatically.
  • Installs into $RUNNER_TEMP/lychee/bin instead of $HOME.
  • Updated actions/checkout and actions/cache internally.
  • Behavior changes in lychee 0.24.x that affect link checking (per the action's release notes): line and column numbers in reports, text-fragment checking (#:~:text=), sitemap.xml input, JUnit output, and explicit timeout handling.

Impact on this repo

  • Call sites: 1, in .github/workflows/build-docs.yml (the validate job, line 75). It runs on PRs and pushes.
  • The step uses args with --no-progress --scheme https --scheme http --user-agent "...". Those flags are unaffected by the 0.24 changes.
  • Text-fragment checking is new. Any link containing #:~:text= will now be checked against the page content. The earlier search of the repo found none, so this should not cause new failures today.
  • Pinning does not change which lychee version runs. The @v2 tag already resolves to the same commit as v2.9.0.

What to alter when upgrading

Option A (recommended): leave @v2. It already points at v2.9.0 and will track future v2 patches.

Option B: pin to lycheeverse/[email protected] for reproducibility. This means updating the pin manually for each release.

Verification

  1. Run the validate job on a PR.
  2. Confirm the lychee step reports the expected link count and no new failures.
  3. If pinning, confirm the step still resolves lychee v0.24.x in the log.

Risk

Very low. The workflow's behavior is unchanged for existing inputs, and the @v2 tag already resolves to v2.9.0.

主要語言
C#
星號
184
分支
48
平均合併
12 分鐘
30 天內合併 PR
21

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

CommunityToolkit/Datasync 的其他 Issue

查看 CommunityToolkit/Datasync 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。