Infra: pin lycheeverse/lychee-action to v2.9.0 (optional)

Abierto
  • ¿Algo no está bien?
#618 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
25/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, yaml
Área
ci-cd

Línea de trabajo

The workflow call site is .github/workflows/build-docs.yml, in the validate job. Read the lychee step and choose whether to keep the floating @v2 tag or pin it to @v2.9.0; the issue says both currently resolve to the same commit. If you pin it, run the validate job on a PR and confirm the lychee step succeeds and reports the expected version.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

dependencies Infrastructure

Summary

Pin lycheeverse/lychee-action from the floating @v2 to @v2.9.0 (latest release). This is optional. @v2 already resolves to the same commit as @v2.9.0, so this is about making the version explicit, not about picking up a new release.

What changed upstream (v2.8.0 → v2.9.0)

  • Default lychee binary bumped from v0.23.0 to v0.24.2. Upstream lychee 0.24.x changed the archive layout, and the action now detects it automatically.
  • Installs into $RUNNER_TEMP/lychee/bin instead of $HOME.
  • Updated actions/checkout and actions/cache internally.
  • Behavior changes in lychee 0.24.x that affect link checking (per the action's release notes): line and column numbers in reports, text-fragment checking (#:~:text=), sitemap.xml input, JUnit output, and explicit timeout handling.

Impact on this repo

  • Call sites: 1, in .github/workflows/build-docs.yml (the validate job, line 75). It runs on PRs and pushes.
  • The step uses args with --no-progress --scheme https --scheme http --user-agent "...". Those flags are unaffected by the 0.24 changes.
  • Text-fragment checking is new. Any link containing #:~:text= will now be checked against the page content. The earlier search of the repo found none, so this should not cause new failures today.
  • Pinning does not change which lychee version runs. The @v2 tag already resolves to the same commit as v2.9.0.

What to alter when upgrading

Option A (recommended): leave @v2. It already points at v2.9.0 and will track future v2 patches.

Option B: pin to lycheeverse/[email protected] for reproducibility. This means updating the pin manually for each release.

Verification

  1. Run the validate job on a PR.
  2. Confirm the lychee step reports the expected link count and no new failures.
  3. If pinning, confirm the step still resolves lychee v0.24.x in the log.

Risk

Very low. The workflow's behavior is unchanged for existing inputs, and the @v2 tag already resolves to v2.9.0.

Lenguaje dominante
C#
Estrellas
184
Forks
48
Merge medio
12 min
PR fusionados (30 d)
21

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CommunityToolkit/Datasync

Todos los issues de CommunityToolkit/Datasync

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.