Infra: pin lycheeverse/lychee-action to v2.9.0 (optional)

Aperta
  • Qualcosa non va?
#618 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
1/5
Tempo stimato
Meno di un'ora
Idoneità per principianti
25/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, yaml
Ambito
ci-cd

Direzione di ricerca

The workflow call site is .github/workflows/build-docs.yml, in the validate job. Read the lychee step and choose whether to keep the floating @v2 tag or pin it to @v2.9.0; the issue says both currently resolve to the same commit. If you pin it, run the validate job on a PR and confirm the lychee step succeeds and reports the expected version.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

dependencies Infrastructure

Summary

Pin lycheeverse/lychee-action from the floating @v2 to @v2.9.0 (latest release). This is optional. @v2 already resolves to the same commit as @v2.9.0, so this is about making the version explicit, not about picking up a new release.

What changed upstream (v2.8.0 → v2.9.0)

  • Default lychee binary bumped from v0.23.0 to v0.24.2. Upstream lychee 0.24.x changed the archive layout, and the action now detects it automatically.
  • Installs into $RUNNER_TEMP/lychee/bin instead of $HOME.
  • Updated actions/checkout and actions/cache internally.
  • Behavior changes in lychee 0.24.x that affect link checking (per the action's release notes): line and column numbers in reports, text-fragment checking (#:~:text=), sitemap.xml input, JUnit output, and explicit timeout handling.

Impact on this repo

  • Call sites: 1, in .github/workflows/build-docs.yml (the validate job, line 75). It runs on PRs and pushes.
  • The step uses args with --no-progress --scheme https --scheme http --user-agent "...". Those flags are unaffected by the 0.24 changes.
  • Text-fragment checking is new. Any link containing #:~:text= will now be checked against the page content. The earlier search of the repo found none, so this should not cause new failures today.
  • Pinning does not change which lychee version runs. The @v2 tag already resolves to the same commit as v2.9.0.

What to alter when upgrading

Option A (recommended): leave @v2. It already points at v2.9.0 and will track future v2 patches.

Option B: pin to lycheeverse/[email protected] for reproducibility. This means updating the pin manually for each release.

Verification

  1. Run the validate job on a PR.
  2. Confirm the lychee step reports the expected link count and no new failures.
  3. If pinning, confirm the step still resolves lychee v0.24.x in the log.

Risk

Very low. The workflow's behavior is unchanged for existing inputs, and the @v2 tag already resolves to v2.9.0.

Lingua principale
C#
Stelle
184
Fork
48
Merge medio
12m
PR unite (30g)
21

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CommunityToolkit/Datasync

Tutte le issue di CommunityToolkit/Datasync

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.