MCP builder tools return wrong results without an error: `min`/`max` of a DateTime is 0, and unknown options such as `having` are silently ignored
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 55/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- clickhouse, typescript
研究方向
Start with packages/common-utils/src/core/renderChartConfig.ts around lines 540–543 and packages/api/src/mcp/tools/query/table.ts around line 32; compare the generated aggregate SQL and how the input schema handles unknown keys. Reproduce both cases using the SQL example in the issue and a clickstack_table call with having. Done means DateTime min/max return timestamps and unsupported options produce a validation error or are applied as specified.
由索引模型根據 Issue 內容生成。
描述
Summary
Two cases where clickstack_table / clickstack_timeseries return a plausible-looking answer that is wrong, with no error or warning. Agents can't tell, so they build conclusions on them.
min/maxon a DateTime column return 0. Every non-count aggregate wraps its value intoFloat64OrDefault(toString(expr))(packages/common-utils/src/core/renderChartConfig.ts:540-543). ForDate/DateTime/DateTime64,toString()gives'2026-11-04 08:00:00.000000000', which doesn't parse as a float, so every value becomes 0 andmax(Timestamp)is 0.- Unknown options are dropped. The tool input schemas are plain
z.object(...)(e.g.tableSchemainpackages/api/src/mcp/tools/query/table.ts:32), so zod strips keys it doesn't know.having: "lines > 5"is accepted, the SQL has noHAVING, and rows with 1 come back. Agents tryhavingbecause dashboard tiles support it (packages/api/src/mcp/tools/dashboards/schemas.ts:839).
Environment
HyperDX 2-nightly image (late Oct 2026) with ClickHouse 26.10.3. Code references checked on main at d08b2fa7 (2026-11-03, 2.43.1).
Steps to reproduce
clickstack_tableon a log or trace source,select: [{aggFn: "min", valueExpression: "Timestamp", alias: "first_seen"}, {aggFn: "max", valueExpression: "Timestamp", alias: "last_seen"}], any time range with data.- Result:
first_seen: 0, last_seen: 0. The SQL insystem.query_logismax(toFloat64OrDefault(toString(Timestamp))).
The cast alone, on any ClickHouse:
WITH arrayJoin([toDateTime64('2026-11-04 07:59:01.123', 9), toDateTime64('2026-11-04 08:00:00', 9)]) AS Timestamp
SELECT max(toFloat64OrDefault(toString(Timestamp))) AS rendered, max(Timestamp) AS expected
-- rendered = 0, expected = 2026-11-04 08:00:00.000000000
clickstack_tablewithgroupByandhaving: "count > 5": no validation error, the generated SQL has noHAVING, and groups with count 1 are returned.
Expected vs actual
| Expected | Actual | |
|---|---|---|
max(Timestamp) |
the latest timestamp (or a clear error) | 0 |
unknown option having |
a validation error naming the valid options, or having applied |
silently ignored |
Impact
In 4 agent investigations on production-size data (about 170 MCP calls), 3 asked "first seen / last seen" questions and got 0 back, and 2 used having and got unfiltered results (one call returned 1,044 groups, which then hit response trimming, see #3542).
Proposed fix
min,maxandanydon't need a Float64 value. Pass the expression through uncast for them, or convert dates numerically (e.g.toUnixTimestamp64Milli) instead of viatoString. The aggregate already handles numbers and numeric strings today, so a type check (date-like → no cast) keeps that behaviour.- Make the MCP tool input schemas
.strict(), so an unknown key returns a validation error listing the accepted options. Addinghavingandlimittoclickstack_tableitself, as tiles already support, is part of #3542.
Related
- #3542: MCP response trimming, and
clickstack_tablehas nolimit,havingor default order - #3499:
valueExpressionignored on metric selects - #2311 / #3237:
count_distincton metric tiles
- 主要語言
- TypeScript
- 星號
- 10.1k
- 分支
- 527
- 平均合併
- 1 天 20 小時
- 30 天內合併 PR
- 186
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
ClickHouse/ClickStack 的其他 Issue
-
external
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3761 ·
維護者通常 1 天內回覆
-
Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several arguments可能已有人在做 @CG-5228 於 26 天前認領。 未關閉external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3477 · 1 則留言 ·
維護者通常 1 天內回覆
-
Slack notifications for inline alerts fail when the chart-explorer link passes Slack's 3000-character block limit可能已有人在做 @Tyagiquamar 於 27 天前認領。 未關閉alerting bug external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3452 ·
維護者通常 1 天內回覆
-
check-alerts worker: 13 error spans (mongodb.create, NamespaceExists) every minute because mongoose autoCreate is still on可能重新可做 關聯的 PR 已關閉且未合併。 未關閉bug external Needs Feedback
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3308 · 1 則留言 ·
維護者通常 1 天內回覆
-
count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric Values可能已有人在做 @Harshul1484 於 54 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#2311 ·
維護者通常 1 天內回覆
查看 ClickHouse/ClickStack 的全部 Issue
相似的 Issue
-
Add: GTrekker未關閉check:passed streams:add
難度 1/5 1 小時以內 新手友好度 72/100
維護者通常 1 天內回覆
-
area: ui Bug Payload OSS
難度 1/5 1 小時以內 新手友好度 88/100
payloadcms/payload#19839 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
維護者通常 1 天內回覆
-
fix(auth): add the email OTP verification step to Pollar login可能已有人在做 @akansnoro 今天認領。 未關閉Stellar Wave
難度 2/5 1-3 小時 新手友好度 74/100
safetrustcr/dApp-SafeTrust#584 · 10 則留言 ·
維護者通常 1 天內回覆
-
The manager preset saves launch definitions without the required file and digest pair可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉bug
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆