Filter sidebar ServiceName values are incomplete — unordered `LIMIT` sample misses services as ingest volume grows

未關閉
#3,465 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
52/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
clickhouse, react, typescript

研究方向

Start by tracing the Search page sidebar filter request to the code that builds the ClickHouse query; the issue identifies /api/clickhouse-proxy and shows the current SQL pattern. Check the filter's query and result handling, then verify that distinct values beyond the first 3,000,000 input rows can appear and whether typing triggers a server request. Done means the sidebar can find known values from the selected time range without silently hiding them.

由索引模型根據 Issue 內容生成。

描述

bug external Needs Feedback

Update: root cause identified. See "Actual query and root cause" below — this replaces the original "no network request fires" theory, which turned out to be a symptom, not the cause.

Description

The Search page's filter sidebar for ServiceName (and presumably any other top-level column) does not reliably surface all distinct values. At high ingest volume, specific known-good values never appear in the filter list or its search box, no matter how they're typed.

This used to work correctly on an older HyperDX version (roughly 3-4 months ago, ClickHouse-side ingest volume was significantly lower at the time). It broke gradually as traffic grew — not because of a version regression, but because of how the underlying query is structured.

Actual query and root cause

Captured from the browser (/api/clickhouse-proxy, fired once when the ServiceName filter is opened):

WITH sampledData AS (
  SELECT ServiceName AS param0
  FROM default.otel_traces
  WHERE Timestamp >= fromUnixTimestamp64Milli(<start>)
    AND Timestamp <= fromUnixTimestamp64Milli(<end>)
  LIMIT 3000000
)
SELECT groupUniqArray(10000)(param0) AS param0
FROM sampledData

This does not compute SELECT DISTINCT ServiceName (or an aggregated GROUP BY) over the full time range. It takes an unordered LIMIT 3,000,000 slice of raw rows from the time range, then extracts up to 10,000 distinct ServiceName values from that slice only. Any ServiceName not present in the first 3,000,000 rows the scan happens to read is invisible to the filter — permanently, since no further request fires when the user types in the filter's search box (confirmed via Network tab: zero new requests on typing, only client-side filtering of the one cached result).

Why this is volume-dependent

The otel_traces table (standard ClickStack/OTel schema) is defined as:

ORDER BY (ServiceName, SpanName, toDateTime(Timestamp))

ServiceName is the first sort key, so an unordered scan reads rows in roughly that physical order. In our environment, one single ServiceName alone produced 52 million rows in a 16-minute window — more than 17x the entire 3,000,000-row sample budget by itself. Total ingest across all services in that same window is well over 100M+ rows. A fixed 3,000,000-row sample therefore covers under ~2% of the window, and gets exhausted by whichever services are read "early" (by part/thread order) long before the scan reaches services that sort later or simply live in parts read later — regardless of how important or high-volume those services actually are.

Three to four months ago, with far lower ingest volume, the same fixed 3,000,000-row budget would have covered the large majority (or all) of the window's rows, so effectively every ServiceName showed up — hence "it worked like butter" on an older deployment. As traffic grew, the same code path started silently dropping services with no error, no truncation warning, and no way to recover them via the search box (since search doesn't issue a new query).

Environment

  • HyperDX version: 2.42.0 (self-hosted via ClickStack docker-compose)
  • Source: OTel traces (otel_traces), ORDER BY (ServiceName, SpanName, Timestamp), hourly partitions
  • ServiceName cardinality: ~1,300 distinct values in a 16-minute window (consumer/job-per-feature naming, not a bounded microservice list)
  • Row volume: 52M+ rows for a single ServiceName in a 16-minute window; 100M+ total across all services in the same window

Steps to reproduce

  1. Have a table where one or a few ServiceName/SpanName values dominate row volume (common for high-traffic OTel traces tables).
  2. Open the Search page's ServiceName filter in the sidebar.
  3. Search for a ServiceName known to exist in ClickHouse for the selected time range, but with lower read-order priority relative to the dominant service(s).
  4. Observe it never appears, and typing in the search box fires no new network request.

Expected

The filter should surface all distinct values that actually exist in the selected time range, or at minimum should sample representatively (e.g., via GROUP BY/DISTINCT with a result-count limit, not an input-row-count limit), and/or should issue a fresh, filtered query when the user searches instead of silently filtering a possibly-incomplete cached list.

Actual

Deterministically misses ServiceName values once per-window row volume for other services exceeds the fixed 3,000,000-row sample budget. No error or truncation indicator is shown to the user. Typing to search never re-queries the server.

Suggested fix

Replace the LIMIT <input rows> + groupUniqArray pattern with a query whose limit is on the output (distinct values), not the input (raw rows read) — e.g. SELECT ServiceName FROM otel_traces WHERE <time range> GROUP BY ServiceName LIMIT 10000, or SELECT DISTINCT ServiceName ... LIMIT 10000. This scans the full time range and returns correct results up to the 10k value cap, instead of an arbitrary, volume-dependent, order-dependent slice. If the row-limited sampling exists specifically to bound query cost on very large tables, consider sampling proportionally/randomly (e.g. SAMPLE clause) rather than taking the physically-first N rows, and/or surfacing a "results may be incomplete" indicator when the input-row cap is hit.

Workaround

Bypass the sidebar facet entirely and filter directly via the query bar (ServiceName:"exact-value" in Lucene mode, or ServiceName = 'exact-value' in SQL mode) — this goes straight to ClickHouse and isn't affected by the sampling issue.

主要語言
TypeScript
星號
10.1k
分支
527
平均合併
1 天 20 小時
30 天內合併 PR
186

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

ClickHouse/ClickStack 的其他 Issue

查看 ClickHouse/ClickStack 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。