count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric Values

Abierto Apto para principiantes
#2,311 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@Harshul1484 ya está trabajando en esto.

Desde el 28/9/2026.

  • #3237 de @Harshul1484 — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
clickhouse, sql, typescript

Línea de trabajo

Comienza en packages/common-utils/src/core/renderChartConfig.ts, en translateMetricChartConfig, e inspecciona cómo se traducen los elementos de selección de gauge antes de la generación de SQL. Reproduce la configuración de métrica count_distinct del issue, conserva su valueExpression del atributo y verifica que la consulta generada cuente valores de atributo distintos en lugar de LastValue.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Bug Description

When using count_distinct as the aggFn on a metric tile, the valueExpression is ignored. The generated SQL always counts distinct values of the metric's float Value column rather than the specified attribute expression.

Steps to Reproduce

  1. Create a dashboard tile with displayType: "number" and a metric select using count_distinct with a valueExpression pointing to an attribute:
    {
      "displayType": "number",
      "source": "Metrics",
      "select": [
        {
          "aggFn": "count_distinct",
          "valueExpression": "Attributes['name']",
          "metricName": "argocd_app_info",
          "metricType": "gauge"
        }
      ]
    }
    
  2. Observe the number displayed — for an info metric (where Value is always 1.0), the tile shows 1 or 2 instead of the actual count of distinct attribute values.

Expected Behavior

The tile should display the count of distinct values of Attributes['name'] across all time series for the metric — i.e., the number of distinct applications reported by argocd_app_info.

Direct ClickHouse query gives the correct answer:

SELECT uniqExact(Attributes['name'])
FROM default.otel_metrics_gauge
WHERE MetricName = 'argocd_app_info'
  AND TimeUnix >= now() - INTERVAL 1 HOUR
-- returns 53

Actual Behavior

The generated SQL uses count(DISTINCT LastValue) where LastValue = last_value(Value) — the gauge's numeric value — not the attribute expression:

-- Generated by HyperDX
...
Bucketed AS (
  SELECT
    ...,
    last_value(Value) AS LastValue,   -- <-- always the float metric value
    any(Attributes) AS Attributes
  FROM Source
  GROUP BY AttributesHash, __hdx_time_bucket2
)
SELECT count(DISTINCT LastValue)      -- <-- counts distinct 1.0, 0.0, etc.
FROM Bucketed

Result: 2 (distinct float values) instead of 53 (distinct app names).

Root Cause

In packages/common-utils/src/core/renderChartConfig.ts, translateMetricChartConfig unconditionally overwrites valueExpression with 'LastValue' for gauge metrics before passing the select config to SQL generation:

select: [
  {
    ..._select,
    valueExpression: 'LastValue',  // overwrites user-provided Attributes['name']
    aggCondition: '',
  },
]

The original valueExpression from the user config is never used in metric query translation.

Additional Context

  • The zod schema (externalDashboardSelectItemSchema in packages/api/src/utils/zod.ts) accepts and even requires valueExpression for non-count aggFns on metrics — so the intent to support this exists, but the query translator doesn't honour it.
  • The UI currently has no input for valueExpression on metric tiles, which makes sense given it's ignored — but fixing the translator would enable useful aggregations like counting distinct label values.
  • Confirmed present in v2.27.0. No prior issue or fix found.

Suggested Fix

For count_distinct (and potentially other aggFns where valueExpression refers to an attribute), use the user-provided expression instead of hardcoding 'LastValue':

// In translateMetricChartConfig for gauge metrics:
const effectiveValueExpression =
  _select.aggFn === 'count_distinct' && _select.valueExpression
    ? _select.valueExpression
    : 'LastValue';

select: [
  {
    ..._select,
    valueExpression: effectiveValueExpression,
    aggCondition: '',
  },
]
Lenguaje dominante
TypeScript
Estrellas
10.1k
Forks
527
Merge medio
1 d 20 h
PR fusionados (30 d)
186

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ClickHouse/ClickStack

Todos los issues de ClickHouse/ClickStack

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.