CallableChecker accepts any truthy result of its callable since 4.1.8

Open
  • Is something wrong?
#767 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
php
Domain
backend-api-design

Research direction

Start with CallableChecker::checkClaim() and checkHeader(), then inspect CallableCheckerTest::theCallableDoesNotReturnABoolean() and .ci-tools/rector.php. Add separate claim and header cases for the listed non-boolean results, and confirm both methods refuse every result other than true while the Rector job preserves that behavior. Update the changelog to explain the return-value requirement.

Written by the indexing model from the issue text.

Description

bug
Version(s) affected

4.1.8 to 4.1.10, 4.2.0 to 4.2.5, and the 4.3.x and 5.0.x branches. 3.4.x and 4.0.x are not affected.

Description

From 3.3.0 to 4.1.7, Jose\Component\Checker\CallableChecker accepted a claim or header value only when its callable returned true; any other result was a refusal. Since 4.1.8, any truthy result accepts the value: 1, a non-empty string, a non-empty array, an object.

The strict comparison was lost in a Rector rewrite (SimplifyBoolIdenticalTrueRector) in 6c2bdcff, in both checkClaim() and checkHeader():

-        if (call_user_func($this->callable, $value) !== true) {
+        if (! call_user_func($this->callable, $value)) {

Rector trusts the docblock callable(mixed $value): bool, which nothing enforces at run time. Callables that return a boolean behave as before. A callable that reports a refusal with a truthy value (an error message, a list of errors, an object, a non-zero code) now accepts the value it means to refuse.

CallableCheckerTest::theCallableDoesNotReturnABoolean() did not catch it: it calls expectException() twice in one method. The claim part now returns without exception, and the header part (fn () => 0) throws the exception the second expectException() waits for, so the test passes with both versions of the class.

How to reproduce
use Jose\Component\Checker\CallableChecker;

$checker = new CallableChecker('scope', static fn (mixed $scope): mixed => $scope === 'invoices:write' ? true : 'scope not allowed');
$checker->checkClaim('invoices:read');

// 4.1.7: InvalidClaimException 'The "scope" claim is invalid.'
// 4.1.8 and later: no exception
Possible Solution
  • Restore !== true in both methods.
  • Skip SimplifyBoolIdenticalTrueRector for this file in .ci-tools/rector.php, otherwise the Rector job rewrites it again, and say in the constructor docblock that any result other than true is a refusal. Keeping the : bool return type in the docblock lets static analysers flag callables such as preg_match().
  • Replace the test with one claim test and one header test, each expecting a single exception, fed by a data provider: false, null, 0, 1, -1, a string, an array, an object.
  • Changelog: a callable that relies on truthiness, e.g. fn ($v) => preg_match('/…/', $v), refuses every value again, as before 4.1.8; it has to return a boolean.
Additional Context

Found by the Anthropic OSS Scanner (ANT-2026-IIOME38Z).

Dominant language
PHP
Stars
954
Forks
119
Avg merge
48m
Merged PRs (30d)
17

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from web-token/jwt-framework

All issues in web-token/jwt-framework

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.