CallableChecker accepts any truthy result of its callable since 4.1.8

Aperta
  • Qualcosa non va?
#767 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
76/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php
Ambito
backend-api-design

Direzione di ricerca

Start with CallableChecker::checkClaim() and checkHeader(), then inspect CallableCheckerTest::theCallableDoesNotReturnABoolean() and .ci-tools/rector.php. Add separate claim and header cases for the listed non-boolean results, and confirm both methods refuse every result other than true while the Rector job preserves that behavior. Update the changelog to explain the return-value requirement.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
Version(s) affected

4.1.8 to 4.1.10, 4.2.0 to 4.2.5, and the 4.3.x and 5.0.x branches. 3.4.x and 4.0.x are not affected.

Description

From 3.3.0 to 4.1.7, Jose\Component\Checker\CallableChecker accepted a claim or header value only when its callable returned true; any other result was a refusal. Since 4.1.8, any truthy result accepts the value: 1, a non-empty string, a non-empty array, an object.

The strict comparison was lost in a Rector rewrite (SimplifyBoolIdenticalTrueRector) in 6c2bdcff, in both checkClaim() and checkHeader():

-        if (call_user_func($this->callable, $value) !== true) {
+        if (! call_user_func($this->callable, $value)) {

Rector trusts the docblock callable(mixed $value): bool, which nothing enforces at run time. Callables that return a boolean behave as before. A callable that reports a refusal with a truthy value (an error message, a list of errors, an object, a non-zero code) now accepts the value it means to refuse.

CallableCheckerTest::theCallableDoesNotReturnABoolean() did not catch it: it calls expectException() twice in one method. The claim part now returns without exception, and the header part (fn () => 0) throws the exception the second expectException() waits for, so the test passes with both versions of the class.

How to reproduce
use Jose\Component\Checker\CallableChecker;

$checker = new CallableChecker('scope', static fn (mixed $scope): mixed => $scope === 'invoices:write' ? true : 'scope not allowed');
$checker->checkClaim('invoices:read');

// 4.1.7: InvalidClaimException 'The "scope" claim is invalid.'
// 4.1.8 and later: no exception
Possible Solution
  • Restore !== true in both methods.
  • Skip SimplifyBoolIdenticalTrueRector for this file in .ci-tools/rector.php, otherwise the Rector job rewrites it again, and say in the constructor docblock that any result other than true is a refusal. Keeping the : bool return type in the docblock lets static analysers flag callables such as preg_match().
  • Replace the test with one claim test and one header test, each expecting a single exception, fed by a data provider: false, null, 0, 1, -1, a string, an array, an object.
  • Changelog: a callable that relies on truthiness, e.g. fn ($v) => preg_match('/…/', $v), refuses every value again, as before 4.1.8; it has to return a boolean.
Additional Context

Found by the Anthropic OSS Scanner (ANT-2026-IIOME38Z).

Lingua principale
PHP
Stelle
954
Fork
119
Merge medio
48m
PR unite (30g)
17

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di web-token/jwt-framework

Tutte le issue di web-token/jwt-framework

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.