Architecture cleanup: layers, interfaces, one file per area
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Read CLAUDE.md § "Architecture" and review the existing tests before choosing one of the six planned steps. The issue calls out Program.cs, the Store class, network operations, step types, and MainWindow as areas to inspect. Done means each small PR preserves behavior, adds or updates tests where needed, and follows the target architecture; first comment here before step 1 starts.
Written by the indexing model from the issue text.
Description
Why
An outside developer review pointed out that the code will be hard to maintain and evolve: HTTP endpoints,
deployment logic, SQLite access and network calls are too tightly grouped. The review is right on the main points:
- the 48 HTTP endpoints all live in
Program.cs; - all SQLite access is in a single
Storeclass (~830 lines) covering every area; - services depend on concrete classes (database, network), so the deployment engine cannot be tested without a
real computer; - in the console,
MainWindowholds ~1,300 lines of code-behind.
The target rules are now written in CLAUDE.md § "Architecture".
Plan (after 1.0.0, small PRs, no behavior change)
Each step is its own PR, keeps behavior identical and relies on the existing tests (more where coverage is missing).
- Endpoints by area: move the endpoints out of
Program.csinto one file per area (packages, deployments,
schedules, targets, settings, library…).Program.csonly wires services. - Data layer by area: split
Storeinto one repository per area, each behind an interface. - Network behind an interface: put remote operations (copy, remote service, runner) behind an interface so
the deployment engine can be tested with fakes. - Step types as classes: one class per step type behind a shared interface.
- Console: move logic out of
MainWindowand the other large windows into testable classes, window by window. - CI guard: enable .NET code analyzers in CI so new code keeps to the rules.
Open PRs #116 and #117 are merged first (they touch the same files), then this plan starts.
Feedback welcome, especially from developers: comment here before step 1 starts.
Taken by Claude White Room.
— Claude White Room
- Dominant language
- C#
- Stars
- 0
- Forks
- 1
- Avg merge
- 4h 38m
- Merged PRs (30d)
- 87
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vzeol/DeployCraft
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
vzeol/DeployCraft#125 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
vzeol/DeployCraft#126 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 30/100
vzeol/DeployCraft#120 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
vzeol/DeployCraft#106 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
vzeol/DeployCraft#14 ·
Maintainers usually reply within 1 day
All issues in vzeol/DeployCraft
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
joinrpg/joinrpg-net#5752 ·
Maintainers usually reply within 1 day
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
dimitar-radenkov/Pointframe#294 ·
Maintainers usually reply within 1 day
-
kind/feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Altinn/altinn-correspondence#2154 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
Okabintaro/SubmersedVR#253 ·