FRAP analysis table: red-on-pink text is 2.21:1 (#1605 audit X3)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start with the FRAP parameter-estimation renderer at vcell-client/.../microscopy/gui/estparamwizard/AnalysisTableRenderer.java, lines ~85-121, where Color.red on (255,170,170) is used for non-identifiable rows. Check GuiConstants for the accessible error-text color added by the #1605 remediation (see docs/accessibility/color-audit.md row X3 for context) and pick a background pairing with it that reaches 4.5:1, then fix the stale 'significant in green' comment. Done means a new unit test asserts ≥ 4.5:1 for every foreground/background pair the renderer uses, and it passes.
Written by the indexing model from the issue text.
Description
Follow-up from the #1605 color audit, row X3 (docs/accessibility/color-audit.md).
Finding. In the FRAP parameter-estimation analysis table (vcell-client/.../microscopy/gui/estparamwizard/AnalysisTableRenderer.java, around lines 85–121), non-identifiable results are shown with the text NOT IDENTIFIABLE (so WCAG 1.4.1 is met). Their cells, though, use Color.red text on a (255,170,170) background, which is 2.21:1, below WCAG 1.4.3's 4.5:1. Plain red text in the same renderer is 4.00:1 on white, also below. The code comment says "significant in green", but the code draws no green.
Fix. Use the accessible error-text color added to GuiConstants by the #1605 remediation, and a background that keeps ≥ 4.5:1 with it. Correct the stale comment.
Acceptance. A unit test asserts ≥ 4.5:1 for every foreground/background pair the renderer uses.
Part of #1603.
- Dominant language
- Java
- Stars
- 140
- Forks
- 35
- Avg merge
- 17h 39m
- Merged PRs (30d)
- 19
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from virtualcell/vcell
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
virtualcell/vcell#2193 · 1 comment ·
Maintainers usually reply within 1 day
-
Accessibility Requirement Java-based User Interface
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
virtualcell/vcell#2138 ·
Maintainers usually reply within 1 day
-
Accessibility Requirement Java-based
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
virtualcell/vcell#2137 ·
Maintainers usually reply within 1 day
-
Accessibility Requirement User Interface
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
virtualcell/vcell#2135 ·
Maintainers usually reply within 1 day
-
Type: enhancement User Interface
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
virtualcell/vcell#2083 ·
Maintainers usually reply within 1 day
All issues in virtualcell/vcell
Similar issues
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
MCP add-on: JSON responses with non-ASCII characters are truncated (wrong Content-Length)Possibly taken @dhanushbs10 claimed this today. Openadd-on bug in:mcp
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
vaadin-map
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
vaadin/flow-components#10586 ·
Maintainers usually reply within 1 day
-
WeReadInstaller writes the launcher database on the main thread at handover (Activity pause timeout)Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
wpilibsuite/SystemcoreTesting#446 ·
Maintainers usually reply within 1 day