chore(ci): check the RustSec advisory database on a schedule, so a new advisory is found on main and not on someone's pull request

Đang mở
  • Có gì không ổn?
#90 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
56/100
Loại issue
Tính năng
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
github-actions, rust
Lĩnh vực
ci-cd, documentation, security

Hướng nghiên cứu

Read .github/workflows/ci.yml for the existing deny job and .github/workflows/flake-hunt.yml for the schedule precedent, then review deny.toml and the supply-chain section of ADR-0101. Add a scheduled, manually dispatchable advisory check and document its failure handling in docs/src/architecture/cicd.md and docs/src/contributing/standards.md; verify the documented control by removing the RUSTSEC-2023-0071 ignore on a throwaway branch and confirming the run names the advisory.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

area:process prio:p1

Context

The deny job (added by #87, closing #40) runs cargo deny --locked check, which fetches the RustSec advisory database on every run, and it is in gate's needs, the only required check. So a newly published advisory turns the job red, and every Rust pull request with it, with no change to the code. Nothing looks at the database between pull requests, so the first person to find out is whoever happens to open one.

This is not hypothetical. When deny.toml was written, seven advisories already failed on main, and two of them (RUSTSEC-2026-0385 and -0387) had been published on 2026-10-23, three days after #40 was filed on 2026-10-20. They were found only because that work ran against the live database.

ci.yml triggers on pull_request, merge_group, push to main and workflow_dispatch. The only scheduled workflow is flake-hunt.yml (weekly).

Problem

  • A new advisory is first seen on an unrelated pull request, which is then red for a reason it did not cause.
  • main can be red-in-waiting for as long as nobody pushes.

Proposal

  • A scheduled workflow that runs cargo deny --locked check advisories against main, with the same pinned cargo-deny and the same deny.toml, and fails visibly when an advisory appears. Decide how it tells someone: a failing scheduled run that watchers are notified of, or one tracking issue it opens and updates. Daily is probably right for something time-sensitive; flake-hunt.yml is weekly.
  • Keep it out of gate: it reports on main, and gate is about the pull request in front of it.
  • Decide whether the pull-request deny job should keep the advisories check. Keeping it means an unrelated advisory blocks every pull request until it is fixed (today's behaviour, fail-closed). Dropping it to licenses bans sources decouples pull requests from drift but leaves advisories to the schedule alone. The schedule does not change which of those you pick; it only makes the warning arrive on main first.
  • Note that flake-hunt.yml records that GitHub disables scheduled workflows in a public repository after 60 days without repository activity.

Acceptance criteria

  • A scheduled workflow exists (actions pinned by SHA, permissions no wider than it needs) and can also be started by workflow_dispatch.
  • The control: on a throwaway branch with the RUSTSEC-2023-0071 ignore deleted from deny.toml, a dispatched run fails and names that advisory (as the throwaway pull request #88 did for the pull-request job).
  • What happens when it fails, and who is told, is written in docs/src/architecture/cicd.md. That page and docs/src/contributing/standards.md ("Decided, and built only in part") now say there is no scheduled check of the advisory database; update both.

References

#40, #87; deny.toml; the deny job in .github/workflows/ci.yml; .github/workflows/flake-hunt.yml (the schedule precedent and the 60-day note); ADR-0101 (.agents/plans/contrail/adrs/ci/0101-ci-supply-chain.md); docs/src/architecture/cicd.md, "Permissions and supply chain".

Ngôn ngữ chính
Rust
Star
0
Fork
0
Merge trung bình
1 giờ 35 phút
Pull request đã merge (30 ngày)
67

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của aRustyDev/thrust

Tất cả issue của aRustyDev/thrust

Issue tương tự

Thêm issue về Rust

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.