chore: fix unchecked errors in test setup and assertions

Open
#73 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
go
Domain
testing

Research direction

Start by reading internal/agentkit/agentkit_test.go for the error-checking pattern, then review the listed test files and run their Go tests. Check every listed setup and assertion error, strengthen TestRunInit_ForceOverwrites to assert the expected content, and add coverage for WorktreeCleanup with cleanupAll=true; done means those cases are checked and the affected tests pass.

Written by the indexing model from the issue text.

Description

cleanup

Context

Review council on PR #61 flagged systematic unchecked errors in test setup and assertion code across multiple test files. These are pre-existing issues, not regressions from #61.

Files

  • cmd/replicator/init_test.go — os.MkdirAll, os.WriteFile, os.ReadFile errors discarded
  • cmd/replicator/serve_test.go — os.MkdirAll, os.WriteFile errors discarded
  • internal/gitutil/git_test.go — WorktreeAdd, os.WriteFile, Run errors discarded
  • internal/forge/worktree_test.go — WorktreeCreate, os.WriteFile, Run errors discarded
  • internal/forge/init_test.go, spawn_test.go, review_test.go, progress_test.go, insights_test.go — DB.Exec, DB.QueryRow().Scan() errors discarded
  • internal/mcp/server_test.go — json.Unmarshal errors discarded in assertions
  • test/parity/parity_test.go — json.Unmarshal errors discarded in setup

Pattern

Replace os.WriteFile(path, data, 0o644) with:

if err := os.WriteFile(path, data, 0o644); err != nil {
    t.Fatalf("setup WriteFile: %v", err)
}

The fix in internal/agentkit/agentkit_test.go (PR #61) shows the correct pattern.

Additional items

  • cmd/replicator/init_test.go:TestRunInit_ForceOverwrites uses a negative-only assertion (checks content is different but not what it should be). Should assert equality with embedded content.
  • internal/forge/worktree_test.go has no test for the cleanupAll=true branch of WorktreeCleanup, contributing to CRAP score 65.9.
Dominant language
Go
Stars
0
Forks
9
Avg merge
1d 14h
Merged PRs (30d)
18

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from unbound-force/replicator

All issues in unbound-force/replicator

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.