chore: fix unchecked errors in test setup and assertions

Abierto
#73 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
go
Área
testing

Línea de trabajo

Start by reading internal/agentkit/agentkit_test.go for the error-checking pattern, then review the listed test files and run their Go tests. Check every listed setup and assertion error, strengthen TestRunInit_ForceOverwrites to assert the expected content, and add coverage for WorktreeCleanup with cleanupAll=true; done means those cases are checked and the affected tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

cleanup

Context

Review council on PR #61 flagged systematic unchecked errors in test setup and assertion code across multiple test files. These are pre-existing issues, not regressions from #61.

Files

  • cmd/replicator/init_test.go — os.MkdirAll, os.WriteFile, os.ReadFile errors discarded
  • cmd/replicator/serve_test.go — os.MkdirAll, os.WriteFile errors discarded
  • internal/gitutil/git_test.go — WorktreeAdd, os.WriteFile, Run errors discarded
  • internal/forge/worktree_test.go — WorktreeCreate, os.WriteFile, Run errors discarded
  • internal/forge/init_test.go, spawn_test.go, review_test.go, progress_test.go, insights_test.go — DB.Exec, DB.QueryRow().Scan() errors discarded
  • internal/mcp/server_test.go — json.Unmarshal errors discarded in assertions
  • test/parity/parity_test.go — json.Unmarshal errors discarded in setup

Pattern

Replace os.WriteFile(path, data, 0o644) with:

if err := os.WriteFile(path, data, 0o644); err != nil {
    t.Fatalf("setup WriteFile: %v", err)
}

The fix in internal/agentkit/agentkit_test.go (PR #61) shows the correct pattern.

Additional items

  • cmd/replicator/init_test.go:TestRunInit_ForceOverwrites uses a negative-only assertion (checks content is different but not what it should be). Should assert equality with embedded content.
  • internal/forge/worktree_test.go has no test for the cleanupAll=true branch of WorktreeCleanup, contributing to CRAP score 65.9.
Lenguaje dominante
Go
Estrellas
0
Forks
9
Merge medio
1 d 14 h
PR fusionados (30 d)
18

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de unbound-force/replicator

Todos los issues de unbound-force/replicator

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.