bug(release): strengthen post-patch cask validation to be stanza-aware
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Newbie friendliness
- 80/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- bash, github-actions
- Domain
- release
Research direction
Open .github/workflows/release.yml and locate the publish-cask job's SHA validation step. Replace the existing grep -q command with the stanza-aware awk check provided in the issue. Verify the syntax by reviewing the workflow or running a local shell test with a sample cask file.
Written by the indexing model from the issue text.
Description
Context
The publish-cask job in release.yml validates the SHA patch with:
grep -q "sha256 \"$ARM64_SHA\"" "$CASK_FILE"
This checks that the SHA exists anywhere in the cask file, not specifically in the darwin_arm64 stanza. Prior to #86, this grep was falsely passing — it found the SHA in the wrong stanza (linux_amd64) and reported success.
With #86 merged the patching logic is correct, but the validation is still not stanza-aware. A future regression in the AWK script could silently pass this check again.
Suggested fix
Replace the grep with a stanza-aware check, e.g.:
if ! awk '/darwin_arm64/{found=1} found && /sha256.*'"$ARM64_SHA"'/{ok=1} END{exit !ok}' "$CASK_FILE"; then
echo "::error::SHA not found in darwin_arm64 stanza"
exit 1
fi
Priority
Low — the core bug is fixed by #86. This is a defense-in-depth improvement
- Dominant language
- Go
- Stars
- 0
- Forks
- 9
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 18
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from unbound-force/replicator
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#95 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#85 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
unbound-force/replicator#77 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#63 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
unbound-force/replicator#52 ·
Maintainers usually reply within 1 day
All issues in unbound-force/replicator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day