[Bug]: Sign-in leaks which usernames exist
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- graphql, rust
- Domain
- authentication, backend, security
Research direction
Start at src/api/auth.rs:242 in the signIn resolver and follow the argon2 verification path, then read startPasskeySignIn at src/api/auth.rs:264 and the throttle branch at src/api/subsonic/mod.rs:215. Run the existing auth tests first to see how sign-in responses are asserted. Done means unknown and known usernames take comparable time and return the same shape on all three paths, with a test covering the unknown-user case.
Written by the indexing model from the issue text.
Description
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
- GraphQL
signInreturns right away when the username doesn't exist, but runs argon2 when it does (src/api/auth.rs:242), so response time tells them apart. startPasskeySignInanswers differently for "no such account"/"no passkeys" vs. an account with passkeys (src/api/auth.rs:264).- In the Subsonic API, unknown usernames spend a throttle guess while known ones using a token don't (
src/api/subsonic/mod.rs:215).
With profiles sign-in on, the profile list already shows accounts, but with username sign-in these let anyone list them.
Steps to reproduce
Time signIn with an existing and a made-up username: the made-up one returns much faster.
Expected behavior
Unknown and known usernames take about the same time and get the same answers.
Suggested fix
Verify against a dummy argon2 hash when the account doesn't exist, return a passkey challenge with no allowed credentials (or the same error) for unknown accounts, and throttle the Subsonic paths the same way for both.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 1
- Avg merge
- 4h 49m
- Merged PRs (30d)
- 5
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tinystream-dev/tinystream
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#132 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#131 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tinystream-dev/tinystream#129 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tinystream-dev/tinystream#128 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tinystream-dev/tinystream#124 ·
All issues in tinystream-dev/tinystream
Similar issues
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
automated issue report
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area/dashboard kind/bug QA/dev-automation
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pydantic/pydantic-ai#13939 ·
Maintainers usually reply within 1 day
-
self-host
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
funmusicplace/mirlo#2625 ·
Maintainers usually reply within 1 day