[Bug]: Sign-in leaks which usernames exist
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- graphql, rust
调研方向
Start at src/api/auth.rs:242 in the signIn resolver and follow the argon2 verification path, then read startPasskeySignIn at src/api/auth.rs:264 and the throttle branch at src/api/subsonic/mod.rs:215. Run the existing auth tests first to see how sign-in responses are asserted. Done means unknown and known usernames take comparable time and return the same shape on all three paths, with a test covering the unknown-user case.
由索引模型根据 Issue 内容生成。
描述
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
- GraphQL
signInreturns right away when the username doesn't exist, but runs argon2 when it does (src/api/auth.rs:242), so response time tells them apart. startPasskeySignInanswers differently for "no such account"/"no passkeys" vs. an account with passkeys (src/api/auth.rs:264).- In the Subsonic API, unknown usernames spend a throttle guess while known ones using a token don't (
src/api/subsonic/mod.rs:215).
With profiles sign-in on, the profile list already shows accounts, but with username sign-in these let anyone list them.
Steps to reproduce
Time signIn with an existing and a made-up username: the made-up one returns much faster.
Expected behavior
Unknown and known usernames take about the same time and get the same answers.
Suggested fix
Verify against a dummy argon2 hash when the account doesn't exist, return a passkey challenge with no allowed credentials (or the same error) for unknown accounts, and throttle the Subsonic paths the same way for both.
- 主要语言
- TypeScript
- 星标
- 4
- 派生
- 1
- 平均合并
- 4 小时 49 分钟
- 30 天内合并 PR
- 5
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
tinystream-dev/tinystream 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
tinystream-dev/tinystream#131 ·
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
tinystream-dev/tinystream#129 ·
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
tinystream-dev/tinystream#128 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
tinystream-dev/tinystream#124 ·
查看 tinystream-dev/tinystream 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 86/100
sandbox-quantum/switch#2163 ·
维护者通常 1 天内回复
-
automated issue report
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复
-
area/dashboard kind/bug QA/dev-automation
难度 1/5 1 小时以内 新手友好度 75/100
维护者通常 1 天内回复
-
bug pydanty:is-working
难度 2/5 1-3 小时 新手友好度 82/100
pydantic/pydantic-ai#13939 ·
维护者通常 1 天内回复
-
self-host
难度 2/5 1-3 小时 新手友好度 70/100
funmusicplace/mirlo#2625 ·
维护者通常 1 天内回复