[Bug]: Sign-in leaks which usernames exist
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 55/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- graphql, rust
研究方向
Start at src/api/auth.rs:242 in the signIn resolver and follow the argon2 verification path, then read startPasskeySignIn at src/api/auth.rs:264 and the throttle branch at src/api/subsonic/mod.rs:215. Run the existing auth tests first to see how sign-in responses are asserted. Done means unknown and known usernames take comparable time and return the same shape on all three paths, with a test covering the unknown-user case.
由索引模型根據 Issue 內容生成。
描述
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
- GraphQL
signInreturns right away when the username doesn't exist, but runs argon2 when it does (src/api/auth.rs:242), so response time tells them apart. startPasskeySignInanswers differently for "no such account"/"no passkeys" vs. an account with passkeys (src/api/auth.rs:264).- In the Subsonic API, unknown usernames spend a throttle guess while known ones using a token don't (
src/api/subsonic/mod.rs:215).
With profiles sign-in on, the profile list already shows accounts, but with username sign-in these let anyone list them.
Steps to reproduce
Time signIn with an existing and a made-up username: the made-up one returns much faster.
Expected behavior
Unknown and known usernames take about the same time and get the same answers.
Suggested fix
Verify against a dummy argon2 hash when the account doesn't exist, return a passkey challenge with no allowed credentials (or the same error) for unknown accounts, and throttle the Subsonic paths the same way for both.
- 主要語言
- TypeScript
- 星號
- 4
- 分支
- 1
- 平均合併
- 4 小時 49 分鐘
- 30 天內合併 PR
- 5
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
tinystream-dev/tinystream 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#131 ·
-
bug
難度 1/5 1 小時以內 新手友好度 88/100
tinystream-dev/tinystream#129 ·
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
tinystream-dev/tinystream#128 ·
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
tinystream-dev/tinystream#124 ·
查看 tinystream-dev/tinystream 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 86/100
sandbox-quantum/switch#2163 ·
維護者通常 1 天內回覆
-
automated issue report
難度 1/5 1 小時以內 新手友好度 78/100
維護者通常 1 天內回覆
-
area/dashboard kind/bug QA/dev-automation
難度 1/5 1 小時以內 新手友好度 75/100
維護者通常 1 天內回覆
-
bug pydanty:is-working
難度 2/5 1-3 小時 新手友好度 82/100
pydantic/pydantic-ai#13939 ·
維護者通常 1 天內回覆
-
self-host
難度 2/5 1-3 小時 新手友好度 70/100
funmusicplace/mirlo#2625 ·
維護者通常 1 天內回覆