The OAuth callback test route only answers for Bluesky

Open Beginner friendly
#230 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
api

Research direction

The callback route /v1/platforms/{platform}/oauth/callback reuses the client-metadata allowlist that only holds bluesky, and returns a 404 saying "OAuth client metadata not available". Start in the route handler and the allowlist it shares, and read the existing test that covers only an unknown platform. Done means the callback answers for an installed OAuth2 adapter, either by dropping the allowlist for this route or by correcting the message, with a new test that installs an OAuth2 adapter.

Written by the indexing model from the issue text.

Description

enhancement

/v1/platforms/{platform}/oauth/callback reuses the client-metadata allowlist, which only holds bluesky, and its 404 says "OAuth client metadata not available". Its docstring describes it as a redirect target for OAuth2 testing, which suggests it should answer for any installed OAuth2 adapter. The existing test only covers an unknown platform.

We could drop the allowlist for the callback, or keep it and fix the message, and add a test with an OAuth2 adapter installed.

Dominant language
Python
Stars
16
Forks
5
Avg merge
7h 44m
Merged PRs (30d)
25

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from smswithoutborders/RelaySMS-Publisher

All issues in smswithoutborders/RelaySMS-Publisher

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.