manage.sh update can leave every service stopped

Open Beginner friendly
  • Is something wrong?
#219 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
bash, markdown, shell
Domain
devops

Research direction

Start in the update branch of manage.sh, where services are stopped before git reset --keep @{upstream} runs, and check what happens when the reset fails. Pick either a check that runs before any service is stopped or a restart on the failure path, then update the steps in docs/operating/upgrading.md to match. Done when a refused reset leaves the services running, or restarts them, and the upgrade docs describe that behaviour.

Written by the indexing model from the issue text.

Description

bug

manage.sh update stops the services before running git reset --keep @{upstream}. When the reset refuses because tracked files have local edits, the script exits and the services stay stopped.

We could run the reset (or a dry check) before stopping anything, or restart the services when the update fails. docs/operating/upgrading.md would then need updating.

Dominant language
Python
Stars
16
Forks
5
Avg merge
8h 23m
Merged PRs (30d)
18

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from smswithoutborders/RelaySMS-Publisher

All issues in smswithoutborders/RelaySMS-Publisher

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.