manage.sh logs --unit fails on a named instance

Closed Beginner friendly
#217 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
shell
Domain
cli, devops

Research direction

The bug is in the logs subcommand of manage.sh, which builds the systemd unit name relaysms-publisher-<name>.service without the instance name. Compare it with how other subcommands call the unit_name_for helper and switch logs --unit to the same pattern. Done when manage.sh logs --unit <name> finds the unit on an install made with --instance-name, and the change is verified by running that command on such an install.

Written by the indexing model from the issue text.

Description

bug good first issue

manage.sh logs --unit <short name> builds relaysms-publisher-<name>.service without the instance name, so on an install made with --instance-name it finds no unit.

We could build the name with unit_name_for "relaysms-publisher-${name}.service", as the other commands do.

Dominant language
Python
Stars
16
Forks
9
Avg merge
8h 41m
Merged PRs (30d)
26

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from smswithoutborders/RelaySMS-Publisher

All issues in smswithoutborders/RelaySMS-Publisher

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.