Timewarped Item Support

Open
  • Is something wrong?
#4,994 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
game-dev

Research direction

Start by locating how the Warforged Variable Pulse Lightning Capacitor and other Timewarped item effects are represented and simulated; the issue does not name files or tests. Compare the simulator's result for the reported trinket with the in-game behavior described here. Done means its equip effect is simulated accurately enough to address the reported DPS discrepancy.

Written by the indexing model from the issue text.

Description

enhancement help wanted Item

I received a Timwarped, Warforged Variable Pulse Lightning Capacitor. In practice, it is pulling very high dps. In the simulation, it's not so hot. I believe the equip effect may not being simulated correctly. Might be worth a look for this trinket and other Timewarped items with affects.

I've tried other simulator addons that are simming this trinket much better, but I'm not so sure about the accuracy.

In normal situations with timewarped items, they would not be worth simming, but, becuase this one titanforged, it's worth a look for me.

Dominant language
C++
Stars
1.6k
Forks
789
Avg merge
13h 25m
Merged PRs (30d)
52

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simulationcraft/simc

All issues in simulationcraft/simc

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.